HackSoftware/Django-Styleguide
1
1
Fork 0
mirror of https://github.com/HackSoftware/Django-Styleguide.git synced 2025-10-31 15:47:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #27 from HackSoftware/fix-spacing

Browse Source 
Fixed spacing and tabulation & renamed imports
This commit is contained in:
Ventsislav Tashev 2019-10-27 16:08:55 +02:00 committed by GitHub
commit 00b8d772ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@ -193,10 +193,10 @@ from datetime import timedelta
from django.test import TestCase from django.test import TestCase
from django.core.exceptions import ValidationError from django.core.exceptions import ValidationError
from odin.common.utils import get_now from project.common.utils import get_now
from odin.education.factories import CourseFactory from project.education.factories import CourseFactory
from odin.education.models import Course from project.education.models import Course
class CourseTests(TestCase): class CourseTests(TestCase):
@ -212,7 +212,6 @@ class CourseTests(TestCase):
with self.assertRaises(ValidationError): with self.assertRaises(ValidationError):
course.full_clean() course.full_clean()
``` ```
There's a lot going on in this test: There's a lot going on in this test:
@ -427,6 +426,7 @@ Here is a good example of service that preforms some validation and raises `djan
```python ```python
from django.core.exceptions import ValidationError from django.core.exceptions import ValidationError
def create_topic(*, name: str, course: Course) -> Topic: def create_topic(*, name: str, course: Course) -> Topic:
if course.end_date < timezone.now(): if course.end_date < timezone.now():
raise ValidationError('You can not create topics for course that has ended.') raise ValidationError('You can not create topics for course that has ended.')