HackSoftware/Django-Styleguide
1
1
Fork 0
mirror of https://github.com/HackSoftware/Django-Styleguide.git synced 2024-09-21 11:29:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

Small tweaks in wording

Browse Source
This commit is contained in:
Radoslav Georgiev 2018-12-28 19:28:10 +02:00
parent 5105e53b7a
commit b29cc49545
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@ -202,13 +202,13 @@ The implementation of `inline_serializer` can be found in `utils.py` in this rep
## Exception Handling
### Raising Exceptions in Services
### Raising Exceptions in Services / Selectors
Now we have separation between our HTTP interface & the core logic of our application.
In order to keep this separation of concerns, our services must not use the `rest_framework.exception` classes because they are bounded with HTTP status codes.
In order to keep this separation of concerns, our services and selectors must not use the `rest_framework.exception` classes because they are bounded with HTTP status codes.
Our services must use one of:
Our services and selectors must use one of:
* [Python built-in exceptions](https://docs.python.org/3/library/exceptions.html)
* Exceptions from `django.core.exceptions`
@ -230,7 +230,7 @@ def create_topic(*, name: str, course: Course) -> Topic:
### Handle Exceptions in APIs
In order to transform the exceptions raised in the services to a standard HTTP response you need to catch the exception and return proper HTTP response.
In order to transform the exceptions raised in the services or selectors, to a standard HTTP response, you need to catch the exception and raise something that the rest framework understands.
The best place to do this is in the `handle_exception` method of the `APIView`.