Merge pull request #26 from HackSoftware/add-default-handled-exceptions

Added information about exceptions that are handled by default from DRF
This commit is contained in:
Ventsislav Tashev 2019-10-27 15:53:11 +02:00 committed by GitHub
commit b4b75bc9a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -440,9 +440,9 @@ def create_topic(*, name: str, course: Course) -> Topic:
In order to transform the exceptions raised in the services or selectors, to a standard HTTP response, you need to catch the exception and raise something that the rest framework understands. In order to transform the exceptions raised in the services or selectors, to a standard HTTP response, you need to catch the exception and raise something that the rest framework understands.
The best place to do this is in the `handle_exception` method of the `APIView`. The best place to do this is in the `handle_exception` method of the `APIView`. There you can map your exception to a DRF exception.
There you can map your exception to DRF exception. [By default, the `handle_exception` method implementation in DRF](https://www.django-rest-framework.org/api-guide/exceptions/#exception-handling-in-rest-framework-views) handles the Django's built-in `Http404` and `PermissionDenied` exceptions, thus there is no need for you to handle it by hand.
Here is an example: Here is an example:
@ -539,7 +539,6 @@ class ExceptionHandlerMixin:
Having this mixin in mind, our API can be written like that: Having this mixin in mind, our API can be written like that:
```python ```python
class CourseCreateApi( class CourseCreateApi(
SomeAuthenticationMixin, SomeAuthenticationMixin,
ExceptionHandlerMixin, ExceptionHandlerMixin,