HackSoftware/Django-Styleguide
1
1
Fork 0
mirror of https://github.com/HackSoftware/Django-Styleguide.git synced 2025-02-07 07:00:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fixed minor typos

Browse Source
This commit is contained in:
Ventsislav Tashev 2019-10-29 20:56:09 +02:00
parent da4f6675a0
commit f5ea212aee
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@ -151,12 +151,12 @@ Few things to spot here.
**Custom validation:** **Custom validation:**
* There's a custom model validation, defined in `clean`. This validation uses only model fields and no relations. * There's a custom model validation, defined in `clean()`. This validation uses only model fields and spans no relations.
* This requires someone to call `full_clean()` on the model instance. The best place to do that is in the `save()` method of the model. Otherwise people can forget to call `full_clean()` in the respective service. * This requires someone to call `full_clean()` on the model instance. The best place to do that is in the `save()` method of the model. Otherwise people can forget to call `full_clean()` in the respective service.
**Properties:** **Properties:**
* All properties, expect `visible_teachers` work directly on model fields. * All properties, except `visible_teachers`, work directly on model fields.
* `visible_teachers` is a great candidate for a **selector**. * `visible_teachers` is a great candidate for a **selector**.
We have few general rules for custom validations & model properties / methods: We have few general rules for custom validations & model properties / methods:
@ -421,7 +421,7 @@ Our services and selectors must use one of:
* Exceptions from `django.core.exceptions` * Exceptions from `django.core.exceptions`
* Custom exceptions, inheriting from the ones above. * Custom exceptions, inheriting from the ones above.
Here is a good example of service that preforms some validation and raises `django.core.exceptions.ValidationError`: Here is a good example of service that performs some validation and raises `django.core.exceptions.ValidationError`:
```python ```python
from django.core.exceptions import ValidationError from django.core.exceptions import ValidationError
@ -852,7 +852,7 @@ def get_items_for_user(
return Item.objects.filter(payments__user=user) return Item.objects.filter(payments__user=user)
``` ```
As you can see, this is a very straighforward & simple selector. We can easily cover that with 2 to 3 tests. As you can see, this is a very straightforward & simple selector. We can easily cover that with 2 to 3 tests.
**Here are the tests:** **Here are the tests:**