Infinidat/infi.clickhouse_orm
1
1
Fork 0
mirror of https://github.com/Infinidat/infi.clickhouse_orm.git synced 2025-07-23 22:39:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

show field name in error when invalid value assigned

Browse Source
This commit is contained in:
Ivan Ladelshchikov 2017-10-10 15:30:37 +04:00
parent a89fd63f4c
commit 50e63fb1f8
2 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/infi/clickhouse_orm/models.py
View File

@ -1,7 +1,8 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import sys
from logging import getLogger from logging import getLogger
from six import with_metaclass from six import with_metaclass, reraise
import pytz import pytz
from .fields import Field, StringField from .fields import Field, StringField
@ -124,8 +125,13 @@ class Model(with_metaclass(ModelBase)):
''' '''
field = self.get_field(name) field = self.get_field(name)
if field: if field:
value = field.to_python(value, pytz.utc) try:
field.validate(value) value = field.to_python(value, pytz.utc)
field.validate(value)
except ValueError:
tp, v, tb = sys.exc_info()
new_msg = "{} (field '{}')".format(v, name)
reraise(tp, tp(new_msg), tb)
super(Model, self).__setattr__(name, value) super(Model, self).__setattr__(name, value)
def set_database(self, db): def set_database(self, db):

21
tests/test_models.py
View File

@ -79,6 +79,27 @@ class ModelTestCase(unittest.TestCase):
"datetime_field": datetime.datetime(1970, 1, 1, 0, 0, 0, tzinfo=pytz.utc) "datetime_field": datetime.datetime(1970, 1, 1, 0, 0, 0, tzinfo=pytz.utc)
}) })
def test_field_name_in_error_message_for_invalid_value_in_constructor(self):
bad_value = 1
with self.assertRaises(ValueError) as cm:
SimpleModel(str_field=bad_value)
self.assertEqual(
"Invalid value for StringField: {} (field 'str_field')".format(repr(bad_value)),
text_type(cm.exception)
)
def test_field_name_in_error_message_for_invalid_value_in_assignment(self):
instance = SimpleModel()
bad_value = 'foo'
with self.assertRaises(ValueError) as cm:
instance.float_field = bad_value
self.assertEqual(
"Invalid value for Float32Field - {} (field 'float_field')".format(repr(bad_value)),
text_type(cm.exception)
)
class SimpleModel(Model): class SimpleModel(Model):