LonamiWebs/Telethon
1
1
Fork 0
mirror of https://github.com/LonamiWebs/Telethon.git synced 2025-03-28 13:54:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Log requests that trigger struct.error

Browse Source 
The exception hardly provides any valuable information.
This will hopefully help troubleshooting why the error happens.
This commit is contained in:
Lonami Exo 2020-02-20 13:40:08 +01:00
parent 7ffb87170b
commit 1e94fe25fa
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
telethon/network/mtprotosender.py
View File

@ -1,5 +1,6 @@
import asyncio import asyncio
import collections import collections
import struct
from . import authenticator from . import authenticator
from ..extensions.messagepacker import MessagePacker from ..extensions.messagepacker import MessagePacker
@ -169,7 +170,14 @@ class MTProtoSender:
raise ConnectionError('Cannot send requests while disconnected') raise ConnectionError('Cannot send requests while disconnected')
if not utils.is_list_like(request): if not utils.is_list_like(request):
state = RequestState(request, self._loop) try:
state = RequestState(request, self._loop)
except struct.error as e:
# "struct.error: required argument is not an integer" is not
# very helpful; log the request to find out what wasn't int.
self._log.error('Request caused struct.error: %s: %s', e, request)
raise
self._send_queue.append(state) self._send_queue.append(state)
return state.future return state.future
else: else:
@ -177,7 +185,12 @@ class MTProtoSender:
futures = [] futures = []
state = None state = None
for req in request: for req in request:
state = RequestState(req, self._loop, after=ordered and state) try:
state = RequestState(req, self._loop, after=ordered and state)
except struct.error as e:
self._log.error('Request caused struct.error: %s: %s', e, request)
raise
states.append(state) states.append(state)
futures.append(state.future) futures.append(state.future)