LonamiWebs/Telethon
1
1
Fork 0
mirror of https://github.com/LonamiWebs/Telethon.git synced 2024-11-13 04:56:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

MtProtoSender: Fix crash on receiving unknown RPC results

Browse Source 
Such RPC results may arrive after reconnection, for example.
This commit is contained in:
Dmitry D. Chernov 2017-05-19 13:09:22 +10:00 committed by Lonami
parent 930dc99f31
commit 7f787affc6
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
telethon/network/mtproto_sender.py Executable file → Normal file
View File

@ -294,6 +294,8 @@ class MtProtoSender:
inner_length = reader.read_int() inner_length = reader.read_int()
begin_position = reader.tell_position() begin_position = reader.tell_position()
# note: this code is IMPORTANT for skipping RPC results of lost
# requests (for example, ones from the previous connection session)
if not self.process_msg(inner_msg_id, sequence, reader, request): if not self.process_msg(inner_msg_id, sequence, reader, request):
reader.set_position(begin_position + inner_length) reader.set_position(begin_position + inner_length)
@ -372,7 +374,12 @@ class MtProtoSender:
request.on_response(compressed_reader) request.on_response(compressed_reader)
else: else:
reader.seek(-4) reader.seek(-4)
request.on_response(reader) if request_id == request.msg_id:
request.on_response(reader)
else:
# note: if it's really a result for RPC from previous connection
# session, it will be skipped by the handle_container()
Log.w('RPC result found for unknown request (maybe from previous connection session)')
def handle_gzip_packed(self, msg_id, sequence, reader, request): def handle_gzip_packed(self, msg_id, sequence, reader, request):
Log.d('Handling gzip packed data') Log.d('Handling gzip packed data')