mirror of
https://github.com/LonamiWebs/Telethon.git
synced 2024-11-13 04:56:35 +03:00
Propagate errors at the connection level
This commit is contained in:
parent
f3414d134a
commit
acd3407418
|
@ -296,8 +296,10 @@ class Connection(abc.ABC):
|
||||||
This method returns a coroutine.
|
This method returns a coroutine.
|
||||||
"""
|
"""
|
||||||
while self._connected:
|
while self._connected:
|
||||||
result = await self._recv_queue.get()
|
result, err = await self._recv_queue.get()
|
||||||
if result: # None = sentinel value = keep trying
|
if err:
|
||||||
|
raise err
|
||||||
|
if result:
|
||||||
return result
|
return result
|
||||||
|
|
||||||
raise ConnectionError('Not connected')
|
raise ConnectionError('Not connected')
|
||||||
|
@ -324,37 +326,29 @@ class Connection(abc.ABC):
|
||||||
"""
|
"""
|
||||||
This loop is constantly putting items on the queue as they're read.
|
This loop is constantly putting items on the queue as they're read.
|
||||||
"""
|
"""
|
||||||
while self._connected:
|
try:
|
||||||
try:
|
while self._connected:
|
||||||
data = await self._recv()
|
try:
|
||||||
except asyncio.CancelledError:
|
data = await self._recv()
|
||||||
break
|
except (IOError, asyncio.IncompleteReadError) as e:
|
||||||
except Exception as e:
|
self._log.warning('Server closed the connection: %s', e)
|
||||||
if isinstance(e, (IOError, asyncio.IncompleteReadError)):
|
await self._recv_queue.put((None, e))
|
||||||
msg = 'The server closed the connection'
|
except InvalidChecksumError as e:
|
||||||
self._log.info(msg)
|
self._log.warning('Server response had invalid checksum: %s', e)
|
||||||
elif isinstance(e, InvalidChecksumError):
|
await self._recv_queue.put((None, e))
|
||||||
msg = 'The server response had an invalid checksum'
|
except InvalidBufferError as e:
|
||||||
self._log.info(msg)
|
self._log.warning('Server response had invalid buffer: %s', e)
|
||||||
elif isinstance(e, InvalidBufferError):
|
await self._recv_queue.put((None, e))
|
||||||
msg = 'The server response had an invalid buffer'
|
except Exception:
|
||||||
self._log.error(msg)
|
self._log.exception('Unexpected exception in the receive loop')
|
||||||
|
await self._recv_queue.put((None, e))
|
||||||
else:
|
else:
|
||||||
msg = 'Unexpected exception in the receive loop'
|
await self._recv_queue.put((data, None))
|
||||||
self._log.exception(msg)
|
except asyncio.CancelledError:
|
||||||
|
pass
|
||||||
|
finally:
|
||||||
|
await self.disconnect()
|
||||||
|
|
||||||
await self.disconnect()
|
|
||||||
|
|
||||||
# Add a sentinel value to unstuck recv
|
|
||||||
if self._recv_queue.empty():
|
|
||||||
self._recv_queue.put_nowait(None)
|
|
||||||
|
|
||||||
break
|
|
||||||
|
|
||||||
try:
|
|
||||||
await self._recv_queue.put(data)
|
|
||||||
except asyncio.CancelledError:
|
|
||||||
break
|
|
||||||
|
|
||||||
def _init_conn(self):
|
def _init_conn(self):
|
||||||
"""
|
"""
|
||||||
|
|
Loading…
Reference in New Issue
Block a user