Shield disconnect from cancellation

Relevant issue: #3942.
This commit is contained in:
Lonami Exo 2022-10-03 10:19:14 +02:00
parent 908375ac42
commit ad2238e788

View File

@ -598,7 +598,11 @@ class TelegramBaseClient(abc.ABC):
await client.disconnect() await client.disconnect()
""" """
if self.loop.is_running(): if self.loop.is_running():
return self._disconnect_coro() # Disconnect may be called from an event handler, which would
# cancel itself during itself and never actually complete the
# disconnection. Shield the task to prevent disconnect itself
# from being cancelled. See issue #3942 for more details.
return asyncio.shield(self.loop.create_task(self._disconnect_coro()))
else: else:
try: try:
self.loop.run_until_complete(self._disconnect_coro()) self.loop.run_until_complete(self._disconnect_coro())