Mis-nesting of aria roles on sidebar navigation

This commit is contained in:
ryan-garrett 2022-06-13 13:30:52 +01:00
parent 2100b549c0
commit 322cbbc3aa
No known key found for this signature in database
GPG Key ID: A4D4C3B91BB547E3
2 changed files with 2 additions and 2 deletions

View File

@ -45,7 +45,7 @@ describe('Search', () => {
getSearchInput().type('{enter}', { force: true }); getSearchInput().type('{enter}', { force: true });
cy.contains('[role=navigation] [role=menuitem]', 'Introduction').should('have.class', 'active'); cy.contains('[role=menu] [role=menuitem]', 'Introduction').should('have.class', 'active');
}); });
it('should mark search results', () => { it('should mark search results', () => {

View File

@ -26,7 +26,7 @@ export class MenuItems extends React.Component<MenuItemsProps> {
className={className} className={className}
style={this.props.style} style={this.props.style}
expanded={expanded} expanded={expanded}
{...(root ? { role: 'navigation' } : {})} {...(root ? { role: 'menu' } : {})}
> >
{items.map((item, idx) => ( {items.map((item, idx) => (
<MenuItem key={idx} item={item} onActivate={this.props.onActivate} /> <MenuItem key={idx} item={item} onActivate={this.props.onActivate} />