From 35df477388cb2707d380515a3493aae73d426ae0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Fabianski?= Date: Sun, 12 May 2019 21:34:10 +0200 Subject: [PATCH] fix: update apiKey in to be titleize (#902) --- .../SecuritySchemes/SecuritySchemes.tsx | 16 ++++++++-------- src/utils/__tests__/helpers.test.ts | 8 +++++++- src/utils/helpers.ts | 4 ++++ 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/src/components/SecuritySchemes/SecuritySchemes.tsx b/src/components/SecuritySchemes/SecuritySchemes.tsx index 08ca01fd..fc5f3bc0 100644 --- a/src/components/SecuritySchemes/SecuritySchemes.tsx +++ b/src/components/SecuritySchemes/SecuritySchemes.tsx @@ -4,6 +4,7 @@ import { SecuritySchemesModel } from '../../services/models'; import { H2, MiddlePanel, Row, Section, ShareLink } from '../../common-elements'; import { OpenAPISecurityScheme } from '../../types'; +import { titleize } from '../../utils/helpers'; import { Markdown } from '../Markdown/Markdown'; import { StyledMarkdownBlock } from '../Markdown/styled.elements'; @@ -84,7 +85,7 @@ export class SecurityDefs extends React.PureComponent { {scheme.apiKey ? ( - {scheme.apiKey.in} parameter name: + {titleize(scheme.apiKey.in || '')} parameter name: {scheme.apiKey.name} ) : scheme.http ? ( @@ -93,13 +94,12 @@ export class SecurityDefs extends React.PureComponent { HTTP Authorization Scheme {scheme.http.scheme} , - scheme.http.scheme === 'bearer' && - scheme.http.bearerFormat && ( - - Bearer format - "{scheme.http.bearerFormat}" - - ), + scheme.http.scheme === 'bearer' && scheme.http.bearerFormat && ( + + Bearer format + "{scheme.http.bearerFormat}" + + ), ] ) : scheme.openId ? ( diff --git a/src/utils/__tests__/helpers.test.ts b/src/utils/__tests__/helpers.test.ts index e73d4367..e638ac12 100644 --- a/src/utils/__tests__/helpers.test.ts +++ b/src/utils/__tests__/helpers.test.ts @@ -1,5 +1,5 @@ import slugify from 'slugify'; -import { mapWithLast, appendToMdHeading, mergeObjects, safeSlugify } from '../helpers'; +import { appendToMdHeading, mapWithLast, mergeObjects, safeSlugify, titleize } from '../helpers'; describe('Utils', () => { describe('helpers', () => { @@ -68,5 +68,11 @@ describe('Utils', () => { expect(mergeObjects({}, obj1, obj2)).toEqual({ a: ['C'], b: ['D'] }); }); }); + + describe('titleize', () => { + test('should return the string with the first letter capitalized', () => { + expect(titleize('my title')).toEqual('My title'); + }); + }); }); }); diff --git a/src/utils/helpers.ts b/src/utils/helpers.ts index 210748f4..de46f654 100644 --- a/src/utils/helpers.ts +++ b/src/utils/helpers.ts @@ -166,6 +166,10 @@ export function getBasePath(serverUrl: string): string { return new URL(serverUrl).pathname; } +export function titleize(text: string) { + return text.charAt(0).toUpperCase() + text.slice(1); +} + export function removeQueryString(serverUrl: string): string { const url = new URL(serverUrl); url.search = '';