diff --git a/lib/components/Redoc/redoc.spec.ts b/lib/components/Redoc/redoc.spec.ts index 073810e8..9fc6ae14 100644 --- a/lib/components/Redoc/redoc.spec.ts +++ b/lib/components/Redoc/redoc.spec.ts @@ -58,7 +58,7 @@ describe('Redoc components', () => { }); it('should return promise', () => { - let res = Redoc.init(); + let res = Redoc.init().catch(() => {/**/}); res.should.be.instanceof(Promise); }); @@ -66,7 +66,7 @@ describe('Redoc components', () => { spyOn(Redoc, 'hideLoadingAnimation').and.callThrough(); spyOn(Redoc, 'displayError').and.callThrough(); let res = Redoc.init(); - return res.then(() => { + return res.catch(() => { expect(Redoc.hideLoadingAnimation).toHaveBeenCalled(); expect(Redoc.displayError).toHaveBeenCalled(); }); diff --git a/lib/components/Redoc/redoc.ts b/lib/components/Redoc/redoc.ts index e523a4d3..6a6de353 100644 --- a/lib/components/Redoc/redoc.ts +++ b/lib/components/Redoc/redoc.ts @@ -79,10 +79,10 @@ export class Redoc extends BaseComponent implements AfterViewInit { Redoc.hideLoadingAnimation(); Redoc.appRef = appRef; console.log('ReDoc bootstrapped!'); - }, err => { - console.log(err); + }).catch(err => { Redoc.hideLoadingAnimation(); Redoc.displayError(err); + throw err; }); } @@ -97,7 +97,6 @@ export class Redoc extends BaseComponent implements AfterViewInit { } static displayError(err) { - console.log(err); let redocEl = dom.query('redoc'); if (!redocEl) return; let heading = 'Oops... ReDoc failed to render this spec'; diff --git a/lib/components/SideMenu/side-menu.spec.ts b/lib/components/SideMenu/side-menu.spec.ts index fce798f3..f4d139d6 100644 --- a/lib/components/SideMenu/side-menu.spec.ts +++ b/lib/components/SideMenu/side-menu.spec.ts @@ -1,7 +1,7 @@ 'use strict'; import { getChildDebugElement } from '../../../tests/helpers'; -import { Component, provide } from '@angular/core'; +import { Component } from '@angular/core'; import { OptionsService } from '../../services/index'; import { diff --git a/lib/services/schema-normalizer.service.spec.ts b/lib/services/schema-normalizer.service.spec.ts index 64d11026..cab630df 100644 --- a/lib/services/schema-normalizer.service.spec.ts +++ b/lib/services/schema-normalizer.service.spec.ts @@ -111,9 +111,18 @@ describe('Spec Helper', () => { let resolved; beforeAll(() => { let pointer = '/paths/test5/get/parameters/0'; + spyOn(console, 'warn').and.stub(); resolved = normalizer.normalize(specMgr.byPointer(pointer), pointer); }); + afterAll(() => { + (console.warn).and.callThrough(); + }); + + it('should print warning to console', () => { + expect(console.warn).toHaveBeenCalled(); + }); + it('should skip other fields', () => { expect(resolved.$ref).toBeUndefined(); expect(resolved.title).toBeDefined(); diff --git a/tests/schemas/base-component-dereference.json b/tests/schemas/base-component-dereference.json index df5dcebc..21e9bf41 100644 --- a/tests/schemas/base-component-dereference.json +++ b/tests/schemas/base-component-dereference.json @@ -110,8 +110,6 @@ "parameters": [ { "$ref": "#/definitions/CircularTransitive", - "title": "test", - "description": "test" } ] }