Redocly/redoc
1
1
Fork 0
mirror of https://github.com/Redocly/redoc.git synced 2024-11-25 01:53:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

Mis-nesting of aria roles on sidebar navigation (#2050)

Browse Source
This commit is contained in:
Ryan Garrett 2022-06-20 11:30:25 +01:00 committed by GitHub
parent 01ffff7f15
commit 7ca10daf12
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
e2e/integration/search.e2e.ts
View File

@ -45,7 +45,7 @@ describe('Search', () => {
getSearchInput().type('{enter}', { force: true }); getSearchInput().type('{enter}', { force: true });
cy.contains('[role=navigation] [role=menuitem]', 'Introduction').should('have.class', 'active'); cy.contains('[role=menu] [role=menuitem]', 'Introduction').should('have.class', 'active');
}); });
it('should mark search results', () => { it('should mark search results', () => {

2
src/components/SideMenu/MenuItems.tsx
View File

@ -26,7 +26,7 @@ export class MenuItems extends React.Component<MenuItemsProps> {
className={className} className={className}
style={this.props.style} style={this.props.style}
expanded={expanded} expanded={expanded}
{...(root ? { role: 'navigation' } : {})} {...(root ? { role: 'menu' } : {})}
> >
{items.map((item, idx) => ( {items.map((item, idx) => (
<MenuItem key={idx} item={item} onActivate={this.props.onActivate} /> <MenuItem key={idx} item={item} onActivate={this.props.onActivate} />