From 895fa179ee20b2f58c0138ed87af88394760e1bc Mon Sep 17 00:00:00 2001
From: mmeigs <matt.meigs@mongodb.com>
Date: Mon, 10 Apr 2023 09:42:32 -0400
Subject: [PATCH] DOP-3611: reverse options (#37)

---
 options.json                                  |  15 ++-
 src/components/VersionSelector/Option.tsx     |  16 +--
 .../VersionSelector/VersionSelector.tsx       | 115 +++++++++++-------
 .../VersionSelector/styled.elements.ts        |   2 +-
 .../__tests__/VersionSelector.test.tsx        |   6 +-
 .../VersionSelector.test.tsx.snap             |  62 +++++-----
 6 files changed, 119 insertions(+), 97 deletions(-)

diff --git a/options.json b/options.json
index 5304bb74..5c0fa306 100644
--- a/options.json
+++ b/options.json
@@ -5,7 +5,20 @@
       "resourceVersion": "2023-02-14"
     },
     "rootUrl": "https://mongodb.com/docs/atlas/reference/api-resources-spec/v2",
-    "resourceVersions": ["2022-09-09", "2022-10-18", "2023-02-14"]
+    "resourceVersions": [
+      "2022-01-01",
+      "2022-01-18",
+      "2022-02-01",
+      "2022-03-09",
+      "2022-04-18",
+      "2022-05-14",
+      "2022-06-09",
+      "2022-07-18",
+      "2022-08-14",
+      "2022-09-09",
+      "2022-10-18",
+      "2023-02-14"
+    ]
   },
   "backNavigationPath": "https://www.mongodb.com/docs/atlas/",
   "siteTitle": "MongoDB Atlas",
diff --git a/src/components/VersionSelector/Option.tsx b/src/components/VersionSelector/Option.tsx
index d6a3642c..0ae781e9 100644
--- a/src/components/VersionSelector/Option.tsx
+++ b/src/components/VersionSelector/Option.tsx
@@ -4,22 +4,8 @@ import Checkmark from './CheckmarkSvg';
 import { OptionProps } from './types';
 
 export const Option = ({ option, value, selected, onClick, focused }: OptionProps) => {
-  const KEY_ENTER = 'Enter';
-  const KEY_SPACE = ' ';
-
-  const handleKeyPress = (event: React.KeyboardEvent) => {
-    if (event.key === KEY_ENTER || event.key === KEY_SPACE) {
-      onClick(value);
-    }
-  };
-
   return (
-    <StyledLi
-      onClick={() => onClick(value)}
-      onKeyPress={handleKeyPress}
-      selected={selected}
-      focused={focused}
-    >
+    <StyledLi onClick={() => onClick(value)} selected={selected} focused={focused}>
       {selected ? <Checkmark /> : <StyledPlaceholder />}
       <StyledOptionText>{option}</StyledOptionText>
     </StyledLi>
diff --git a/src/components/VersionSelector/VersionSelector.tsx b/src/components/VersionSelector/VersionSelector.tsx
index 50e6284d..8e84d08d 100644
--- a/src/components/VersionSelector/VersionSelector.tsx
+++ b/src/components/VersionSelector/VersionSelector.tsx
@@ -24,33 +24,37 @@ const VersionSelectorComponent = ({
   description,
   rootUrl,
 }: VersionSelectorProps): JSX.Element => {
-  const initialSelectedIdx = resourceVersions.indexOf(active.resourceVersion);
+  const descendingResourceVersions = resourceVersions.slice().reverse();
+  const initialSelectedIdx = descendingResourceVersions.indexOf(active.resourceVersion);
   const [open, setOpen] = React.useState<boolean>(false);
   const [focusedIdx, setFocusedIdx] = React.useState<number>(-1);
   const [selectedIdx, setSelectedIdx] = React.useState<number>(initialSelectedIdx);
 
   const menuListRef = React.useRef(null);
-
-  const options = resourceVersions.map((option, i) => {
-    return (
-      <Option
-        key={`option-${i}`}
-        selected={i === selectedIdx}
-        value={option}
-        option={`${option}${i === resourceVersions.length - 1 ? ' (latest)' : ''}`}
-        onClick={option => handleClick(i, option)}
-        focused={i === focusedIdx}
-      />
-    );
-  });
-
   useOutsideClick(menuListRef, () => {
     if (open) setOpen(false);
     setFocusedIdx(0);
   });
 
+  const handleKeyDownSelect = React.useCallback(() => {
+    if (focusedIdx < 0) return;
+    if (focusedIdx === selectedIdx) return setOpen(false);
+    const resourceVersionReal = descendingResourceVersions[focusedIdx];
+
+    // navigate to resource version spec
+    let selectedResourceVersionUrl = `${rootUrl}/${resourceVersionReal}`;
+    const anchorTagIdx = window.location.href.indexOf('#tag');
+    if (anchorTagIdx > -1) {
+      selectedResourceVersionUrl += window.location.href.slice(anchorTagIdx);
+    }
+    window.location.href = selectedResourceVersionUrl;
+    setSelectedIdx(focusedIdx);
+    return setOpen(false);
+  }, [selectedIdx, rootUrl, focusedIdx, descendingResourceVersions]);
+
   const handleClick = (idx: number, resourceVersion: string) => {
     if (idx === selectedIdx) return setOpen(false);
+    if (resourceVersion === undefined) return setOpen(false);
 
     // navigate to resource version spec
     let selectedResourceVersionUrl = `${rootUrl}/${resourceVersion}`;
@@ -59,44 +63,63 @@ const VersionSelectorComponent = ({
       selectedResourceVersionUrl += window.location.href.slice(anchorTagIdx);
     }
     window.location.href = selectedResourceVersionUrl;
+    setFocusedIdx(idx);
     setSelectedIdx(idx);
     return setOpen(false);
   };
 
-  const handleFocusChange = (event: React.KeyboardEvent<HTMLDivElement>) => {
-    const { key, shiftKey } = event;
+  const handleFocusChange = React.useCallback(
+    (event: React.KeyboardEvent<HTMLDivElement>) => {
+      const { key, shiftKey } = event;
+      if (key === 'ArrowDown' || (key === 'Tab' && !shiftKey)) {
+        // if we go down when we are already past the end, don't do anything
+        if (focusedIdx === descendingResourceVersions.length) return;
 
-    if (key === 'ArrowDown' || (key === 'Tab' && !shiftKey)) {
-      // if we go down when we are already past the end, don't do anything
-      if (focusedIdx === resourceVersions.length) return;
+        if (focusedIdx === -1) {
+          // when first entering the dropdown via the down arrow key or tab,
+          // we want to open the modal
+          setOpen(true);
+        } else if (focusedIdx === descendingResourceVersions.length - 1) {
+          // if we are at the last element of the dropdown, and attempt to go
+          // down again, we want to close the dropdown
+          setOpen(false);
+        }
 
-      if (focusedIdx === -1) {
-        // when first entering the dropdown via the down arrow key or tab,
-        // we want to open the modal
-        setOpen(true);
-      } else if (focusedIdx === resourceVersions.length - 1) {
-        // if we are at the last element of the dropdown, and attempt to go
-        // down again, we want to close the dropdown
-        setOpen(false);
+        setFocusedIdx(focusedIdx + 1);
+      } else if (key === 'ArrowUp' || (key === 'Tab' && shiftKey)) {
+        // if we go down when we are already past the end, don't do anything
+        if (focusedIdx === -1) return;
+
+        if (focusedIdx === descendingResourceVersions.length) {
+          // in this scenario, we are entering the dropdown from below
+          // we open the dropdown and start from the bottom
+          setOpen(true);
+        } else if (focusedIdx === 0) {
+          // if we reach the first element in the drop down, and we attempt to go up again,
+          // we want to close the dropdown
+          setOpen(false);
+        }
+
+        setFocusedIdx(focusedIdx - 1);
+      } else if (key === 'Enter' || key === ' ') {
+        handleKeyDownSelect();
       }
-      setFocusedIdx(focusedIdx + 1);
-    } else if (key === 'ArrowUp' || (key === 'Tab' && shiftKey)) {
-      // if we go down when we are already past the end, don't do anything
-      if (focusedIdx === -1) return;
+    },
+    [focusedIdx, descendingResourceVersions, handleKeyDownSelect],
+  );
 
-      if (focusedIdx === resourceVersions.length) {
-        // in this scenario, we are entering the dropdown from below
-        // we open the dropdown and start from the bottom
-        setOpen(true);
-      } else if (focusedIdx === 0) {
-        // if we reach the first element in the drop down, and we attempt to go up again,
-        // we want to close the dropdown
-        setOpen(false);
-      }
-
-      setFocusedIdx(focusedIdx - 1);
-    }
-  };
+  const options = descendingResourceVersions.map((option, i) => {
+    return (
+      <Option
+        key={`option-${i}`}
+        selected={i === selectedIdx}
+        value={option}
+        option={`${option}${i === 0 ? ' (latest)' : ''}`}
+        onClick={() => handleClick(i, option)}
+        focused={i === focusedIdx}
+      />
+    );
+  });
 
   return (
     <StyledWrapper onKeyDown={handleFocusChange} ref={menuListRef}>
@@ -105,7 +128,7 @@ const VersionSelectorComponent = ({
         {description && <StyledDescription>{description}</StyledDescription>}
         <StyledButton onClick={() => setOpen(!open)}>
           <StyledDisplay>
-            <StyledSelected>{resourceVersions[selectedIdx]}</StyledSelected>
+            <StyledSelected>{descendingResourceVersions[selectedIdx]}</StyledSelected>
             <ArrowIcon open={open} />
           </StyledDisplay>
         </StyledButton>
diff --git a/src/components/VersionSelector/styled.elements.ts b/src/components/VersionSelector/styled.elements.ts
index 370722f9..08cd20d1 100644
--- a/src/components/VersionSelector/styled.elements.ts
+++ b/src/components/VersionSelector/styled.elements.ts
@@ -188,7 +188,7 @@ export const openDropdownStyle = css`
 export const StyledDropdown = styled.div.attrs<{ open: boolean }>({
   role: 'listbox',
   'aria-labelledby': 'View a different version of documentation.',
-  tabIndex: '-1',
+  tabIndex: '0',
 })<{ open: boolean }>`
   ${props => (props.open ? openDropdownStyle : `display: none;`)}
 `;
diff --git a/src/components/__tests__/VersionSelector.test.tsx b/src/components/__tests__/VersionSelector.test.tsx
index 0e523bae..a87eb89b 100644
--- a/src/components/__tests__/VersionSelector.test.tsx
+++ b/src/components/__tests__/VersionSelector.test.tsx
@@ -31,9 +31,9 @@ describe('VersionSelector', () => {
     wrapper.find('button').simulate('click');
     expect(wrapper.find('li')).toHaveLength(3);
 
-    wrapper.find('li').at(0).simulate('click');
+    wrapper.find('li').at(1).simulate('click');
     expect(JSON.stringify(window.location)).toBe(
-      JSON.stringify(`${versionData.rootUrl}/${versionData.resourceVersions[0]}`),
+      JSON.stringify(`${versionData.rootUrl}/${versionData.resourceVersions[1]}`),
     );
   });
 
@@ -42,7 +42,7 @@ describe('VersionSelector', () => {
     wrapper.find('button').simulate('click');
     expect(wrapper.find('li')).toHaveLength(3);
 
-    wrapper.find('li').at(2).simulate('click');
+    wrapper.find('li').at(0).simulate('click');
     expect(JSON.stringify(window.location)).not.toBe(
       JSON.stringify(`${versionData.rootUrl}/${versionData.resourceVersions[2]}`),
     );
diff --git a/src/components/__tests__/__snapshots__/VersionSelector.test.tsx.snap b/src/components/__tests__/__snapshots__/VersionSelector.test.tsx.snap
index 0bf97825..2eaa4f22 100644
--- a/src/components/__tests__/__snapshots__/VersionSelector.test.tsx.snap
+++ b/src/components/__tests__/__snapshots__/VersionSelector.test.tsx.snap
@@ -46,42 +46,12 @@ exports[`VersionSelector should correctly render VersionSelector 1`] = `
     aria-labelledby="View a different version of documentation."
     class="sc-kEqXSa litKaz"
     role="listbox"
-    tabindex="-1"
+    tabindex="0"
   >
     <div>
       <ul
         class="sc-gKAaRy iQghMf"
       >
-        <li
-          aria-selected="false"
-          class="sc-pNWdM kSTcTW"
-          role="option"
-          tabindex="0"
-        >
-          <span
-            class="sc-iqAclL dXUzZL"
-          />
-          <span
-            class="sc-jrsJWt hDLwjI"
-          >
-            2021-09-09
-          </span>
-        </li>
-        <li
-          aria-selected="false"
-          class="sc-pNWdM kSTcTW"
-          role="option"
-          tabindex="0"
-        >
-          <span
-            class="sc-iqAclL dXUzZL"
-          />
-          <span
-            class="sc-jrsJWt hDLwjI"
-          >
-            2022-10-18
-          </span>
-        </li>
         <li
           aria-selected="true"
           class="sc-pNWdM derVNM"
@@ -110,6 +80,36 @@ exports[`VersionSelector should correctly render VersionSelector 1`] = `
             2023-01-01 (latest)
           </span>
         </li>
+        <li
+          aria-selected="false"
+          class="sc-pNWdM kSTcTW"
+          role="option"
+          tabindex="0"
+        >
+          <span
+            class="sc-iqAclL dXUzZL"
+          />
+          <span
+            class="sc-jrsJWt hDLwjI"
+          >
+            2022-10-18
+          </span>
+        </li>
+        <li
+          aria-selected="false"
+          class="sc-pNWdM kSTcTW"
+          role="option"
+          tabindex="0"
+        >
+          <span
+            class="sc-iqAclL dXUzZL"
+          />
+          <span
+            class="sc-jrsJWt hDLwjI"
+          >
+            2021-09-09
+          </span>
+        </li>
       </ul>
     </div>
   </div>