Redocly/redoc
1
1
Fork 0
mirror of https://github.com/Redocly/redoc.git synced 2025-03-21 18:14:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

chore: minor fixes after refactor

Browse Source
This commit is contained in:
Roman Hotsiy 2018-08-17 15:01:18 +03:00
parent 43a22f5531
commit b9c1b49810
No known key found for this signature in database
GPG Key ID: 5CB7B3ACABA57CB0
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/services/HistoryService.ts
View File

@ -4,10 +4,6 @@ import { IS_BROWSER } from '../utils/';
const EVENT = 'hashchange';
function isSameHash(a: string, b: string): boolean {
return a === b || '#' + a === b || a === '#' + b;
}
export class HistoryService {
private _emiter;
@ -21,6 +17,9 @@ export class HistoryService {
}
linkForId(id: string) {
if (!id) {
return '';
}
return '#' + id;
}
@ -52,7 +51,7 @@ export class HistoryService {
return;
}
if (id == null || isSameHash(id, this.currentId)) {
if (id == null || id === this.currentId) {
return;
}
if (rewriteHistory) {
@ -65,6 +64,7 @@ export class HistoryService {
return;
}
window.history.pushState(null, '', window.location.href.split('#')[0] + this.linkForId(id));
this.emit();
}
}

4
src/services/__tests__/history.service.test.ts
View File

@ -31,4 +31,8 @@ describe('History service', () => {
test('should return correct link for id', () => {
expect(history.linkForId('testid')).toEqual('#testid');
});
test('should return empty link for empty id', () => {
expect(history.linkForId('')).toEqual('');
});
});