Redocly/redoc
1
1
Fork 0
mirror of https://github.com/Redocly/redoc.git synced 2025-03-03 17:35:46 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: menu service subscription leak + minor refactor

Browse Source
This commit is contained in:
Roman Hotsiy 2017-04-30 14:31:22 +03:00
parent 9ea672d921
commit bb00dc3426
No known key found for this signature in database
GPG Key ID: 5CB7B3ACABA57CB0
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/services/menu.service.ts
View File

@ -35,7 +35,7 @@ export interface MenuItem {
active?: boolean; active?: boolean;
ready?: boolean; ready?: boolean;
depth?: number; depth?: string|number;
flatIdx?: number; flatIdx?: number;
metadata?: any; metadata?: any;
@ -72,7 +72,11 @@ export class MenuService {
this.buildMenu(); this.buildMenu();
}); });
this._scrollSubscription = scrollService.scroll.subscribe((evt) => { this.subscribe();
}
subscribe() {
this._scrollSubscription = this.scrollService.scroll.subscribe((evt) => {
this.onScroll(evt.isScrolledDown); this.onScroll(evt.isScrolledDown);
}); });
@ -478,5 +482,6 @@ export class MenuService {
destroy() { destroy() {
this._hashSubscription.unsubscribe(); this._hashSubscription.unsubscribe();
this._scrollSubscription.unsubscribe(); this._scrollSubscription.unsubscribe();
this._progressSubscription.unsubscribe();
} }
} }