Small fixes

This commit is contained in:
Maksymilian Fryc 2017-08-17 13:49:11 +02:00
parent 43527b197d
commit cd348d18e9
4 changed files with 14 additions and 14 deletions

View File

@ -68,10 +68,10 @@ describe('Redoc components', () => {
it('should confirm that component is sorted', () => {
let firstMenuItemsListLength = fixedMenuItemsList.length;
for(var firstMenuItemIndex = 0; firstMenuItemIndex < firstMenuItemsListLength; firstMenuItemIndex++) {
if(fixedMenuItemsList[firstMenuItemIndex].items !== null) {
for (var firstMenuItemIndex = 0; firstMenuItemIndex < firstMenuItemsListLength; firstMenuItemIndex++) {
if (fixedMenuItemsList[firstMenuItemIndex].items !== null) {
let secondMenuItemsListLength = fixedMenuItemsList[firstMenuItemIndex].items.length;
for(var secondMenuItemIndex = 0; secondMenuItemIndex < secondMenuItemsListLength; secondMenuItemIndex++) {
for (var secondMenuItemIndex = 0; secondMenuItemIndex < secondMenuItemsListLength; secondMenuItemIndex++) {
component.menuItems[firstMenuItemIndex].items[secondMenuItemIndex].name.should.be.equal(fixedMenuItemsList[firstMenuItemIndex].items[secondMenuItemIndex].name);
}
}

View File

@ -116,14 +116,14 @@ export class SideMenu implements OnInit, OnDestroy {
this.menuItems = this.menuService.items;
let firstMenuItemsLength = this.menuItems.length;
for(var firstMenuItemIndex = 0; firstMenuItemIndex < firstMenuItemsLength; firstMenuItemIndex++) {
if(this.menuItems[firstMenuItemIndex].items !== null) {
for (var firstMenuItemIndex = 0; firstMenuItemIndex < firstMenuItemsLength; firstMenuItemIndex++) {
if (this.menuItems[firstMenuItemIndex].items !== null) {
let secondMenuItemsLength = this.menuItems[firstMenuItemIndex].items.length;
for(var secondMenuItemIndex = 0; secondMenuItemIndex < secondMenuItemsLength; secondMenuItemIndex++) {
if(this.menuItems[firstMenuItemIndex].items[secondMenuItemIndex].items == null) {
for (var secondMenuItemIndex = 0; secondMenuItemIndex < secondMenuItemsLength; secondMenuItemIndex++) {
if (this.menuItems[firstMenuItemIndex].items[secondMenuItemIndex].items == null) {
this.menuItems[firstMenuItemIndex].items.sort(endpointComparator);
}
else{
else {
this.menuItems[firstMenuItemIndex].items[secondMenuItemIndex].items.sort(endpointComparator);
}
}

View File

@ -3,18 +3,18 @@ export const endpointComparator = (a, b) => {
let operationComparisonResult: number;
let nameComparisonResult: number = a.name.localeCompare(b.name);
if(a.metadata.sortOrder != null && b.metadata.sortOrder != null) {
if (a.metadata.sortOrder != null && b.metadata.sortOrder != null) {
sortOrderComparisonResult = a.metadata.sortOrder.localeCompare(b.metadata.sortOrder);
}
if(a.metadata.operation != null && b.metadata.operation != null) {
if (a.metadata.operation != null && b.metadata.operation != null) {
operationComparisonResult = a.metadata.operation.localeCompare(b.metadata.operation);
}
if(sortOrderComparisonResult != null && sortOrderComparisonResult !== 0) {
if (sortOrderComparisonResult != null && sortOrderComparisonResult !== 0) {
return sortOrderComparisonResult;
}
else if(operationComparisonResult != null && operationComparisonResult !== 0) {
else if (operationComparisonResult != null && operationComparisonResult !== 0) {
return operationComparisonResult;
}
else {

View File

@ -335,8 +335,8 @@ export class MenuService {
let xSortOrder;
let orderInfo = operationInfo['x-sort-order'];
if(orderInfo != null) {
if(orderInfo >= 0 && orderInfo < tag.operations.length && Number.isInteger(orderInfo)) {
if (orderInfo != null) {
if (orderInfo >= 0 && orderInfo < tag.operations.length && Number.isInteger(orderInfo)) {
xSortOrder = operationInfo['x-sort-order'];
}
}