Show title and description on schemas, fix #598.

This commit is contained in:
Jarosław Rzeszótko 2018-08-10 16:01:35 +02:00
parent 822d038190
commit ec3b260056
5 changed files with 156 additions and 128 deletions

View File

@ -3,13 +3,6 @@
import styled, { extensionsHook, withProps } from '../styled-components';
import { deprecatedCss } from './mixins';
export const PropertiesTableCaption = styled.caption`
text-align: right;
font-size: 0.9em;
font-weight: normal;
color: ${props => props.theme.colors.text.secondary};
`;
export const PropertyCell = styled.td`
border-left: 1px solid ${props => props.theme.schema.linesColor};
box-sizing: border-box;

View File

@ -74,7 +74,6 @@ export class Field extends React.Component<FieldProps> {
schema={field.schema}
skipReadOnly={this.props.skipReadOnly}
skipWriteOnly={this.props.skipWriteOnly}
showTitle={this.props.showTitle}
/>
</InnerPropertiesWrap>
</PropertyCellWithInner>

View File

@ -1,10 +1,15 @@
import { observer } from 'mobx-react';
import * as React from 'react';
import styled from '../../styled-components';
import { SchemaModel } from '../../services/models';
import { PropertiesTable, PropertiesTableCaption } from '../../common-elements/fields-layout';
import { PropertiesTable } from '../../common-elements/fields-layout';
import { H3 } from '../../common-elements/headers';
import { Field } from '../Fields/Field';
import { Markdown } from '../Markdown/Markdown';
import { DiscriminatorDropdown } from './DiscriminatorDropdown';
import { SchemaProps } from './Schema';
@ -17,6 +22,18 @@ export interface ObjectSchemaProps extends SchemaProps {
};
}
export const ObjectSchemaDetails = styled.div`
margin: 0 0 0.5em 0;
`;
export const ObjectSchemaTitle = styled(H3)`
margin: 0.5em 0 0 0;
`;
export const ObjectSchemaDescription = styled.div`
margin: 0.5em 0 0 0;
`;
@observer
export class ObjectSchema extends React.Component<ObjectSchemaProps> {
get parentSchema() {
@ -26,7 +43,6 @@ export class ObjectSchema extends React.Component<ObjectSchemaProps> {
render() {
const {
schema: { fields = [] },
showTitle,
discriminator,
} = this.props;
@ -42,36 +58,44 @@ export class ObjectSchema extends React.Component<ObjectSchemaProps> {
: fields;
return (
<PropertiesTable>
{showTitle && <PropertiesTableCaption>{this.props.schema.title}</PropertiesTableCaption>}
<tbody>
{mapWithLast(filteredFields, (field, isLast) => {
return (
<Field
key={field.name}
isLast={isLast}
field={field}
renderDiscriminatorSwitch={
(discriminator &&
discriminator.fieldName === field.name &&
(() => (
<DiscriminatorDropdown
parent={this.parentSchema}
enumValues={field.schema.enum}
/>
))) ||
undefined
}
className={field.expanded ? 'expanded' : undefined}
showExamples={false}
skipReadOnly={this.props.skipReadOnly}
skipWriteOnly={this.props.skipWriteOnly}
showTitle={this.props.showTitle}
/>
);
})}
</tbody>
</PropertiesTable>
<div>
<ObjectSchemaDetails>
<ObjectSchemaTitle>{this.props.schema.title}</ObjectSchemaTitle>
<ObjectSchemaDescription>
<Markdown dense={true} source={this.props.schema.description} />
</ObjectSchemaDescription>
</ObjectSchemaDetails>
<PropertiesTable>
<tbody>
{mapWithLast(filteredFields, (field, isLast) => {
return (
<Field
key={field.name}
isLast={isLast}
field={field}
renderDiscriminatorSwitch={
(discriminator &&
discriminator.fieldName === field.name &&
(() => (
<DiscriminatorDropdown
parent={this.parentSchema}
enumValues={field.schema.enum}
/>
))) ||
undefined
}
className={field.expanded ? 'expanded' : undefined}
showExamples={false}
skipReadOnly={this.props.skipReadOnly}
skipWriteOnly={this.props.skipWriteOnly}
/>
);
})}
</tbody>
</PropertiesTable>
</div>
);
}
}

View File

@ -11,7 +11,6 @@ import { ObjectSchema } from './ObjectSchema';
import { OneOfSchema } from './OneOfSchema';
export interface SchemaOptions {
showTitle?: boolean;
skipReadOnly?: boolean;
skipWriteOnly?: boolean;
}

View File

@ -1,105 +1,118 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`Components SchemaView discriminator should correctly render discriminator dropdown 1`] = `
<styled.table>
<tbody>
<Field
field={
FieldModel {
"deprecated": false,
"description": "",
"example": undefined,
"expanded": false,
"in": undefined,
"kind": "field",
"name": "packSize",
"required": false,
"schema": SchemaModel {
"activeOneOf": 0,
"constraints": Array [],
"default": undefined,
<div>
<styled.div>
<Styled(styled.h2)>
Dog
</Styled(styled.h2)>
<styled.div>
<Markdown
dense={true}
source=""
/>
</styled.div>
</styled.div>
<styled.table>
<tbody>
<Field
field={
FieldModel {
"deprecated": false,
"description": "",
"displayFormat": undefined,
"displayType": "number",
"enum": Array [],
"example": undefined,
"format": undefined,
"isCircular": undefined,
"isPrimitive": true,
"nullable": false,
"options": "<<<filtered>>>",
"pattern": undefined,
"pointer": "#/components/schemas/Dog/properties/packSize",
"rawSchema": Object {
"expanded": false,
"in": undefined,
"kind": "field",
"name": "packSize",
"required": false,
"schema": SchemaModel {
"activeOneOf": 0,
"constraints": Array [],
"default": undefined,
"deprecated": false,
"description": "",
"displayFormat": undefined,
"displayType": "number",
"enum": Array [],
"example": undefined,
"format": undefined,
"isCircular": undefined,
"isPrimitive": true,
"nullable": false,
"options": "<<<filtered>>>",
"pattern": undefined,
"pointer": "#/components/schemas/Dog/properties/packSize",
"rawSchema": Object {
"default": undefined,
"type": "number",
},
"readOnly": false,
"schema": Object {
"default": undefined,
"type": "number",
},
"title": "",
"type": "number",
"typePrefix": "",
"writeOnly": false,
},
"readOnly": false,
"schema": Object {
"default": undefined,
"type": "number",
},
"title": "",
"type": "number",
"typePrefix": "",
"writeOnly": false,
},
}
}
}
isLast={false}
key="packSize"
showExamples={false}
/>
<Field
field={
FieldModel {
"deprecated": false,
"description": "",
"example": undefined,
"expanded": false,
"in": undefined,
"kind": "field",
"name": "type",
"required": true,
"schema": SchemaModel {
"activeOneOf": 0,
"constraints": Array [],
"default": undefined,
isLast={false}
key="packSize"
showExamples={false}
/>
<Field
field={
FieldModel {
"deprecated": false,
"description": "",
"displayFormat": undefined,
"displayType": "string",
"enum": Array [],
"example": undefined,
"format": undefined,
"isCircular": undefined,
"isPrimitive": true,
"nullable": false,
"options": "<<<filtered>>>",
"pattern": undefined,
"pointer": "#/components/schemas/Dog/properties/type",
"rawSchema": Object {
"expanded": false,
"in": undefined,
"kind": "field",
"name": "type",
"required": true,
"schema": SchemaModel {
"activeOneOf": 0,
"constraints": Array [],
"default": undefined,
"deprecated": false,
"description": "",
"displayFormat": undefined,
"displayType": "string",
"enum": Array [],
"example": undefined,
"format": undefined,
"isCircular": undefined,
"isPrimitive": true,
"nullable": false,
"options": "<<<filtered>>>",
"pattern": undefined,
"pointer": "#/components/schemas/Dog/properties/type",
"rawSchema": Object {
"default": undefined,
"type": "string",
},
"readOnly": false,
"schema": Object {
"default": undefined,
"type": "string",
},
"title": "",
"type": "string",
"typePrefix": "",
"writeOnly": false,
},
"readOnly": false,
"schema": Object {
"default": undefined,
"type": "string",
},
"title": "",
"type": "string",
"typePrefix": "",
"writeOnly": false,
},
}
}
}
isLast={true}
key="type"
renderDiscriminatorSwitch={[Function]}
showExamples={false}
/>
</tbody>
</styled.table>
isLast={true}
key="type"
renderDiscriminatorSwitch={[Function]}
showExamples={false}
/>
</tbody>
</styled.table>
</div>
`;