Update docstring for UserDetailsView and cleanup

This commit is contained in:
Maxim Kukhtenkov 2016-10-31 15:01:06 -07:00
parent 37375461df
commit 70d03e3e9b
2 changed files with 10 additions and 11 deletions

View File

@ -63,11 +63,11 @@ class SocialLoginSerializer(serializers.Serializer):
# http://stackoverflow.com/questions/8666316/facebook-oauth-2-0-code-and-token # http://stackoverflow.com/questions/8666316/facebook-oauth-2-0-code-and-token
# Case 1: We received the access_token # Case 1: We received the access_token
if('access_token' in attrs): if 'access_token' in attrs:
access_token = attrs.get('access_token') access_token = attrs.get('access_token')
# Case 2: We received the authorization code # Case 2: We received the authorization code
elif('code' in attrs): elif 'code' in attrs:
self.callback_url = getattr(view, 'callback_url', None) self.callback_url = getattr(view, 'callback_url', None)
self.client_class = getattr(view, 'client_class', None) self.client_class = getattr(view, 'client_class', None)

View File

@ -9,9 +9,8 @@ from django.utils.translation import ugettext_lazy as _
from rest_framework import status from rest_framework import status
from rest_framework.views import APIView from rest_framework.views import APIView
from rest_framework.response import Response from rest_framework.response import Response
from rest_framework.generics import GenericAPIView from rest_framework.generics import GenericAPIView, RetrieveUpdateAPIView
from rest_framework.permissions import IsAuthenticated, AllowAny from rest_framework.permissions import IsAuthenticated, AllowAny
from rest_framework.generics import RetrieveUpdateAPIView
if 'allauth' in settings.INSTALLED_APPS: if 'allauth' in settings.INSTALLED_APPS:
from allauth.account import app_settings as allauth_settings from allauth.account import app_settings as allauth_settings
@ -22,7 +21,6 @@ from .app_settings import (
PasswordChangeSerializer, JWTSerializer, create_token PasswordChangeSerializer, JWTSerializer, create_token
) )
from .models import TokenModel from .models import TokenModel
from .utils import jwt_encode from .utils import jwt_encode
@ -123,13 +121,14 @@ class LogoutView(APIView):
class UserDetailsView(RetrieveUpdateAPIView): class UserDetailsView(RetrieveUpdateAPIView):
""" """
Returns User's details in JSON format. Reads and updates UserModel fields
Accepts GET, PUT, PATCH methods.
Accepts the following GET parameters: token Default accepted fields: username, first_name, last_name
Accepts the following POST parameters: Default display fields: pk, username, email, first_name, last_name
Required: token Read-only fields: pk, email
Optional: email, first_name, last_name and UserProfile fields
Returns the updated UserProfile and/or User object. Returns UserModel fields.
""" """
serializer_class = UserDetailsSerializer serializer_class = UserDetailsSerializer
permission_classes = (IsAuthenticated,) permission_classes = (IsAuthenticated,)