From 61393b5bff79f33abf2bf611ccadda7a9928eecc Mon Sep 17 00:00:00 2001 From: olivierdalang Date: Thu, 23 May 2019 23:27:23 +0200 Subject: [PATCH 1/2] Fix #346 where is_open_for_signup was ignored --- rest_auth/registration/serializers.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/rest_auth/registration/serializers.py b/rest_auth/registration/serializers.py index 4f99c18..3cafe91 100644 --- a/rest_auth/registration/serializers.py +++ b/rest_auth/registration/serializers.py @@ -8,6 +8,7 @@ try: get_username_max_length) from allauth.account.adapter import get_adapter from allauth.account.utils import setup_user_email + from allauth.socialaccount.adapter import get_adapter from allauth.socialaccount.helpers import complete_social_login from allauth.socialaccount.models import SocialAccount from allauth.socialaccount.providers.base import AuthProcess @@ -139,6 +140,12 @@ class SocialLoginSerializer(serializers.Serializer): _("User is already registered with this e-mail address.") ) + # If signup is disabled, we cannot login a new user + if not get_adapter(request).is_open_for_signup(request, login): + raise serializers.ValidationError( + _("User is not registered but registration is closed.") + ) + login.lookup() login.save(request, connect=True) From 499bf7261572ff51e143e8d19de12ecfdda13bab Mon Sep 17 00:00:00 2001 From: olivierdalang Date: Tue, 18 Jun 2019 00:43:07 +0200 Subject: [PATCH 2/2] fix mistake in imports --- rest_auth/registration/serializers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rest_auth/registration/serializers.py b/rest_auth/registration/serializers.py index 3cafe91..b6f1ebc 100644 --- a/rest_auth/registration/serializers.py +++ b/rest_auth/registration/serializers.py @@ -8,7 +8,7 @@ try: get_username_max_length) from allauth.account.adapter import get_adapter from allauth.account.utils import setup_user_email - from allauth.socialaccount.adapter import get_adapter + from allauth.socialaccount.adapter import get_adapter as get_social_adapter from allauth.socialaccount.helpers import complete_social_login from allauth.socialaccount.models import SocialAccount from allauth.socialaccount.providers.base import AuthProcess @@ -141,7 +141,7 @@ class SocialLoginSerializer(serializers.Serializer): ) # If signup is disabled, we cannot login a new user - if not get_adapter(request).is_open_for_signup(request, login): + if not get_social_adapter(request).is_open_for_signup(request, login): raise serializers.ValidationError( _("User is not registered but registration is closed.") )