Tivix/django-rest-auth
1
1
Fork 0
mirror of https://github.com/Tivix/django-rest-auth.git synced 2024-12-02 13:53:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

changed invalid or expired and blacklisted errors to 401

Browse Source
This commit is contained in:
Marc LaBelle 2020-04-09 21:00:48 -04:00
parent d5d9c69aa3
commit 91c052fe47
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dj_rest_auth/tests/test_api.py
View File

@ -583,13 +583,18 @@ class APIBasicTests(TestsMixin, TestCase):
get_user_model().objects.create_user(self.USERNAME, '', self.PASS) get_user_model().objects.create_user(self.USERNAME, '', self.PASS)
resp = self.post(self.login_url, data=payload, status_code=200) resp = self.post(self.login_url, data=payload, status_code=200)
token = resp.data['refresh_token'] token = resp.data['refresh_token']
# test refresh token not included in request data
resp = self.post(self.logout_url, status=200) resp = self.post(self.logout_url, status=200)
self.assertEqual(resp.status_code, 401) self.assertEqual(resp.status_code, 401)
# test token is invalid or expired
resp = self.post(self.logout_url, status=200, data={'refresh': '1'}) resp = self.post(self.logout_url, status=200, data={'refresh': '1'})
self.assertEqual(resp.status_code, 404) self.assertEqual(resp.status_code, 401)
# test successful logout
resp = self.post(self.logout_url, status=200, data={'refresh': token}) resp = self.post(self.logout_url, status=200, data={'refresh': token})
self.assertEqual(resp.status_code, 200) self.assertEqual(resp.status_code, 200)
# test token is blacklisted
resp = self.post(self.logout_url, status=200, data={'refresh': token}) resp = self.post(self.logout_url, status=200, data={'refresh': token})
self.assertEqual(resp.status_code, 404) self.assertEqual(resp.status_code, 401)
# test other TokenError, AttributeError, TypeError (invalid format)
resp = self.post(self.logout_url, status=200, data=json.dumps({'refresh': token})) resp = self.post(self.logout_url, status=200, data=json.dumps({'refresh': token}))
self.assertEqual(resp.status_code, 500) self.assertEqual(resp.status_code, 500)

2
dj_rest_auth/views.py
View File

@ -159,7 +159,7 @@ class LogoutView(APIView):
if hasattr(error, 'args'): if hasattr(error, 'args'):
if 'Token is blacklisted' in error.args or 'Token is invalid or expired' in error.args: if 'Token is blacklisted' in error.args or 'Token is invalid or expired' in error.args:
response = Response({"detail": _(error.args[0])}, response = Response({"detail": _(error.args[0])},
status=status.HTTP_404_NOT_FOUND) status=status.HTTP_401_UNAUTHORIZED)
else: else:
response = Response({"detail": _("An error has occurred.")}, response = Response({"detail": _("An error has occurred.")},