From a93b7f5cec9873a6eb97a92f055306b11330548b Mon Sep 17 00:00:00 2001 From: Poderyagin Egor Date: Sun, 13 Dec 2015 22:24:27 +0300 Subject: [PATCH 1/6] Added test case for reset by email in different case --- rest_auth/tests/test_api.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/rest_auth/tests/test_api.py b/rest_auth/tests/test_api.py index 7adcf71..b64cf8c 100644 --- a/rest_auth/tests/test_api.py +++ b/rest_auth/tests/test_api.py @@ -224,6 +224,15 @@ class APITestCase1(TestCase, BaseAPITestCase): } self.post(self.login_url, data=payload, status_code=200) + def test_password_reset_with_email_in_different_case(self): + user = get_user_model().objects.create_user(self.USERNAME, self.EMAIL.lower(), self.PASS) + + # call password reset in upper case + mail_count = len(mail.outbox) + payload = {'email': self.EMAIL.upper()} + self.post(self.password_reset_url, data=payload, status_code=200) + self.assertEqual(len(mail.outbox), mail_count + 1) + def test_password_reset_with_invalid_email(self): get_user_model().objects.create_user(self.USERNAME, self.EMAIL, self.PASS) From 411cc298b3a43a772ef906d9a773d37712a473fc Mon Sep 17 00:00:00 2001 From: Will Date: Mon, 21 Dec 2015 11:01:41 -0500 Subject: [PATCH 2/6] Update demo.rst With requirements file of django >= 1.7.0, change command of `syncdb` to `migrate` (`syncdb` is deprecated). --- docs/demo.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/demo.rst b/docs/demo.rst index ed74750..877ca33 100644 --- a/docs/demo.rst +++ b/docs/demo.rst @@ -11,7 +11,7 @@ Do these steps to make it running (ideally in virtualenv). git clone https://github.com/Tivix/django-rest-auth.git cd django-rest-auth/demo/ pip install -r requirements.pip - python manage.py syncdb --settings=demo.settings --noinput + python manage.py migrate --settings=demo.settings --noinput python manage.py runserver --settings=demo.settings Now, go to ``http://127.0.0.1:8000/`` in your browser. From 4d9e33e9a82082c12358c10b87a6ffd4dffad0b2 Mon Sep 17 00:00:00 2001 From: Will Liu Date: Mon, 21 Dec 2015 16:32:53 -0500 Subject: [PATCH 3/6] fix demo by add csrf and modify account settings In response to Issue 116 at https://github.com/Tivix/django-rest-auth/issues/116 * Add csrf_token tags on demo templates (was returning CSRF page) * Update settings file for the demo login (was returning message that email was required when template only shows username and password fields) --- demo/demo/settings.py | 4 ++-- demo/templates/fragments/email_verification_form.html | 2 +- demo/templates/fragments/login_form.html | 2 +- demo/templates/fragments/password_change_form.html | 3 +-- demo/templates/fragments/password_reset_confirm_form.html | 2 +- demo/templates/fragments/password_reset_form.html | 2 +- demo/templates/fragments/signup_form.html | 2 +- demo/templates/fragments/user_details_form.html | 2 +- 8 files changed, 9 insertions(+), 10 deletions(-) diff --git a/demo/demo/settings.py b/demo/demo/settings.py index c82f703..f559d5c 100644 --- a/demo/demo/settings.py +++ b/demo/demo/settings.py @@ -106,9 +106,9 @@ TEMPLATE_DIRS = [os.path.join(BASE_DIR, 'templates')] REST_SESSION_LOGIN = False EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend' SITE_ID = 1 -ACCOUNT_EMAIL_REQUIRED = True +ACCOUNT_EMAIL_REQUIRED = False ACCOUNT_AUTHENTICATION_METHOD = 'username' -ACCOUNT_EMAIL_VERIFICATION = 'mandatory' +ACCOUNT_EMAIL_VERIFICATION = 'optional' REST_FRAMEWORK = { 'DEFAULT_AUTHENTICATION_CLASSES': ( diff --git a/demo/templates/fragments/email_verification_form.html b/demo/templates/fragments/email_verification_form.html index 2298d0e..a718e0b 100644 --- a/demo/templates/fragments/email_verification_form.html +++ b/demo/templates/fragments/email_verification_form.html @@ -1,5 +1,5 @@ -
+{% csrf_token %}
diff --git a/demo/templates/fragments/login_form.html b/demo/templates/fragments/login_form.html index ee02b53..46aba62 100644 --- a/demo/templates/fragments/login_form.html +++ b/demo/templates/fragments/login_form.html @@ -1,5 +1,5 @@ - +{% csrf_token %}
diff --git a/demo/templates/fragments/password_change_form.html b/demo/templates/fragments/password_change_form.html index 9e64ea4..c8dfda5 100644 --- a/demo/templates/fragments/password_change_form.html +++ b/demo/templates/fragments/password_change_form.html @@ -1,6 +1,5 @@ - - +{% csrf_token %}
diff --git a/demo/templates/fragments/password_reset_confirm_form.html b/demo/templates/fragments/password_reset_confirm_form.html index 973b05d..5a9c395 100644 --- a/demo/templates/fragments/password_reset_confirm_form.html +++ b/demo/templates/fragments/password_reset_confirm_form.html @@ -1,5 +1,5 @@ - +{% csrf_token %}
diff --git a/demo/templates/fragments/password_reset_form.html b/demo/templates/fragments/password_reset_form.html index 6840193..0f61344 100644 --- a/demo/templates/fragments/password_reset_form.html +++ b/demo/templates/fragments/password_reset_form.html @@ -1,5 +1,5 @@ - +{% csrf_token %}
diff --git a/demo/templates/fragments/signup_form.html b/demo/templates/fragments/signup_form.html index 9a7e43e..d60b99b 100644 --- a/demo/templates/fragments/signup_form.html +++ b/demo/templates/fragments/signup_form.html @@ -1,5 +1,5 @@ - +{% csrf_token %}
diff --git a/demo/templates/fragments/user_details_form.html b/demo/templates/fragments/user_details_form.html index 405403b..7fafc0a 100644 --- a/demo/templates/fragments/user_details_form.html +++ b/demo/templates/fragments/user_details_form.html @@ -1,5 +1,5 @@ - +{% csrf_token %}
From 23eb6e5be5897ebd5c60003d24597c94a2288763 Mon Sep 17 00:00:00 2001 From: mario Date: Tue, 22 Dec 2015 09:27:17 +0100 Subject: [PATCH 4/6] Added `coverage_html` to .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 8a04b95..85446ba 100644 --- a/.gitignore +++ b/.gitignore @@ -33,6 +33,7 @@ htmlcov/ .cache nosetests.xml coverage.xml +coverage_html # Translations *.mo From 4c8db510b0fa526732c94deabfa3e5bf5c98951e Mon Sep 17 00:00:00 2001 From: mario Date: Tue, 22 Dec 2015 09:28:35 +0100 Subject: [PATCH 5/6] Fixed test exception. --- rest_auth/tests/settings.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/rest_auth/tests/settings.py b/rest_auth/tests/settings.py index 5c7a940..b09b496 100644 --- a/rest_auth/tests/settings.py +++ b/rest_auth/tests/settings.py @@ -70,7 +70,3 @@ INSTALLED_APPS = [ SECRET_KEY = "38dh*skf8sjfhs287dh&^hd8&3hdg*j2&sd" ACCOUNT_ACTIVATION_DAYS = 1 SITE_ID = 1 - -MIGRATION_MODULES = { - 'authtoken': 'authtoken.migrations', -} From 073dd3e76513b9b11ceda7de75e8ca9550783f79 Mon Sep 17 00:00:00 2001 From: mario Date: Tue, 5 Jan 2016 15:09:31 +0100 Subject: [PATCH 6/6] Fixed flake8 warnings --- rest_auth/tests/test_api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rest_auth/tests/test_api.py b/rest_auth/tests/test_api.py index b64cf8c..bb15e01 100644 --- a/rest_auth/tests/test_api.py +++ b/rest_auth/tests/test_api.py @@ -225,7 +225,7 @@ class APITestCase1(TestCase, BaseAPITestCase): self.post(self.login_url, data=payload, status_code=200) def test_password_reset_with_email_in_different_case(self): - user = get_user_model().objects.create_user(self.USERNAME, self.EMAIL.lower(), self.PASS) + get_user_model().objects.create_user(self.USERNAME, self.EMAIL.lower(), self.PASS) # call password reset in upper case mail_count = len(mail.outbox)