carrotquest/django-clickhouse
1
1
Fork 0
mirror of https://github.com/carrotquest/django-clickhouse.git synced 2024-11-14 13:26:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #25 from carrotquest/fix-connection-licks-in-parallel-threads

Browse Source 
Fixed django database connection leaking in child threads
This commit is contained in:
M1ha Shvn 2021-04-01 10:12:43 +05:00 committed by GitHub
commit 2a694ee623
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/django_clickhouse/utils.py
View File

@ -172,11 +172,28 @@ class ExceptionThread(Thread):
super(ExceptionThread, self).__init__(*args, **kwargs) super(ExceptionThread, self).__init__(*args, **kwargs)
self.exc = None self.exc = None
def _close_django_db_connections(self):
"""
In Django every thread has its own database connection pool.
But django does not close them automatically in child threads.
As a result, this can cause database connection leaking.
Here we close connections manually when thread execution is finished.
"""
try:
from django.db import connections as db_connections
except (ModuleNotFoundError, ImportError):
db_connections = None
if db_connections:
db_connections.close_all()
def run(self): def run(self):
try: try:
return super(ExceptionThread, self).run() return super(ExceptionThread, self).run()
except Exception as e: except Exception as e:
self.exc = e self.exc = e
finally:
self._close_django_db_connections()
def join(self, timeout=None): def join(self, timeout=None):
super(ExceptionThread, self).join(timeout=timeout) super(ExceptionThread, self).join(timeout=timeout)