2023-04-28 10:56:22 +03:00
|
|
|
import glob
|
2015-11-09 01:46:38 +03:00
|
|
|
import os
|
|
|
|
import re
|
2021-12-16 14:07:47 +03:00
|
|
|
import sys
|
2015-11-09 01:46:38 +03:00
|
|
|
|
2015-11-09 01:05:32 +03:00
|
|
|
import pytest
|
2021-12-16 14:07:47 +03:00
|
|
|
|
|
|
|
try:
|
|
|
|
import sh
|
|
|
|
except (ImportError, ModuleNotFoundError):
|
|
|
|
sh = None # sh doesn't support Windows
|
2019-04-01 10:47:46 +03:00
|
|
|
import yaml
|
2015-11-09 01:46:38 +03:00
|
|
|
from binaryornot.check import is_binary
|
2021-11-26 18:41:50 +03:00
|
|
|
from cookiecutter.exceptions import FailedHookException
|
2015-11-09 01:46:38 +03:00
|
|
|
|
2019-05-27 18:54:08 +03:00
|
|
|
PATTERN = r"{{(\s?cookiecutter)[.](.*?)}}"
|
2015-11-09 01:46:38 +03:00
|
|
|
RE_OBJ = re.compile(PATTERN)
|
2021-12-22 11:14:00 +03:00
|
|
|
|
|
|
|
if sys.platform.startswith("win"):
|
|
|
|
pytest.skip("sh doesn't support windows", allow_module_level=True)
|
|
|
|
elif sys.platform.startswith("darwin") and os.getenv("CI"):
|
|
|
|
pytest.skip("skipping slow macOS tests on CI", allow_module_level=True)
|
2015-11-09 01:46:38 +03:00
|
|
|
|
2023-04-15 15:21:18 +03:00
|
|
|
# Run auto-fixable styles checks - skipped on CI by default. These can be fixed
|
|
|
|
# automatically by running pre-commit after generation however they are tedious
|
|
|
|
# to fix in the template, so we don't insist too much in fixing them.
|
2023-04-15 17:43:04 +03:00
|
|
|
AUTOFIXABLE_STYLES = os.getenv("AUTOFIXABLE_STYLES") == "1"
|
2023-04-28 10:56:22 +03:00
|
|
|
auto_fixable = pytest.mark.skipif(not AUTOFIXABLE_STYLES, reason="auto-fixable")
|
2023-04-15 15:21:18 +03:00
|
|
|
|
2015-11-09 01:05:32 +03:00
|
|
|
|
|
|
|
@pytest.fixture
|
|
|
|
def context():
|
|
|
|
return {
|
2018-04-09 01:03:29 +03:00
|
|
|
"project_name": "My Test Project",
|
|
|
|
"project_slug": "my_test_project",
|
|
|
|
"author_name": "Test Author",
|
|
|
|
"email": "test@example.com",
|
|
|
|
"description": "A short description of the project.",
|
|
|
|
"domain_name": "example.com",
|
|
|
|
"version": "0.1.0",
|
|
|
|
"timezone": "UTC",
|
2015-11-09 01:05:32 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-02-29 20:15:35 +03:00
|
|
|
SUPPORTED_COMBINATIONS = [
|
2023-04-15 13:53:15 +03:00
|
|
|
{"username_type": "username"},
|
|
|
|
{"username_type": "email"},
|
2020-02-29 20:15:35 +03:00
|
|
|
{"open_source_license": "MIT"},
|
|
|
|
{"open_source_license": "BSD"},
|
|
|
|
{"open_source_license": "GPLv3"},
|
|
|
|
{"open_source_license": "Apache Software License 2.0"},
|
|
|
|
{"open_source_license": "Not open source"},
|
|
|
|
{"windows": "y"},
|
|
|
|
{"windows": "n"},
|
2023-07-03 12:55:33 +03:00
|
|
|
{"editor": "None"},
|
|
|
|
{"editor": "PyCharm"},
|
|
|
|
{"editor": "VS Code"},
|
2020-02-29 20:15:35 +03:00
|
|
|
{"use_docker": "y"},
|
|
|
|
{"use_docker": "n"},
|
2023-07-04 23:14:28 +03:00
|
|
|
{"postgresql_version": "15"},
|
2022-06-13 22:17:46 +03:00
|
|
|
{"postgresql_version": "14"},
|
|
|
|
{"postgresql_version": "13"},
|
|
|
|
{"postgresql_version": "12"},
|
|
|
|
{"postgresql_version": "11"},
|
|
|
|
{"postgresql_version": "10"},
|
2020-02-29 20:15:35 +03:00
|
|
|
{"cloud_provider": "AWS", "use_whitenoise": "y"},
|
|
|
|
{"cloud_provider": "AWS", "use_whitenoise": "n"},
|
|
|
|
{"cloud_provider": "GCP", "use_whitenoise": "y"},
|
|
|
|
{"cloud_provider": "GCP", "use_whitenoise": "n"},
|
2022-11-30 21:26:58 +03:00
|
|
|
{"cloud_provider": "Azure", "use_whitenoise": "y"},
|
|
|
|
{"cloud_provider": "Azure", "use_whitenoise": "n"},
|
2020-03-22 20:31:52 +03:00
|
|
|
{"cloud_provider": "None", "use_whitenoise": "y", "mail_service": "Mailgun"},
|
|
|
|
{"cloud_provider": "None", "use_whitenoise": "y", "mail_service": "Mailjet"},
|
|
|
|
{"cloud_provider": "None", "use_whitenoise": "y", "mail_service": "Mandrill"},
|
|
|
|
{"cloud_provider": "None", "use_whitenoise": "y", "mail_service": "Postmark"},
|
|
|
|
{"cloud_provider": "None", "use_whitenoise": "y", "mail_service": "Sendgrid"},
|
|
|
|
{"cloud_provider": "None", "use_whitenoise": "y", "mail_service": "SendinBlue"},
|
|
|
|
{"cloud_provider": "None", "use_whitenoise": "y", "mail_service": "SparkPost"},
|
|
|
|
{"cloud_provider": "None", "use_whitenoise": "y", "mail_service": "Other SMTP"},
|
2020-02-29 20:15:35 +03:00
|
|
|
# Note: cloud_provider=None AND use_whitenoise=n is not supported
|
2020-03-22 20:31:52 +03:00
|
|
|
{"cloud_provider": "AWS", "mail_service": "Mailgun"},
|
|
|
|
{"cloud_provider": "AWS", "mail_service": "Amazon SES"},
|
|
|
|
{"cloud_provider": "AWS", "mail_service": "Mailjet"},
|
|
|
|
{"cloud_provider": "AWS", "mail_service": "Mandrill"},
|
|
|
|
{"cloud_provider": "AWS", "mail_service": "Postmark"},
|
|
|
|
{"cloud_provider": "AWS", "mail_service": "Sendgrid"},
|
|
|
|
{"cloud_provider": "AWS", "mail_service": "SendinBlue"},
|
|
|
|
{"cloud_provider": "AWS", "mail_service": "SparkPost"},
|
|
|
|
{"cloud_provider": "AWS", "mail_service": "Other SMTP"},
|
|
|
|
{"cloud_provider": "GCP", "mail_service": "Mailgun"},
|
|
|
|
{"cloud_provider": "GCP", "mail_service": "Mailjet"},
|
|
|
|
{"cloud_provider": "GCP", "mail_service": "Mandrill"},
|
|
|
|
{"cloud_provider": "GCP", "mail_service": "Postmark"},
|
|
|
|
{"cloud_provider": "GCP", "mail_service": "Sendgrid"},
|
|
|
|
{"cloud_provider": "GCP", "mail_service": "SendinBlue"},
|
|
|
|
{"cloud_provider": "GCP", "mail_service": "SparkPost"},
|
|
|
|
{"cloud_provider": "GCP", "mail_service": "Other SMTP"},
|
2022-11-30 21:26:58 +03:00
|
|
|
{"cloud_provider": "Azure", "mail_service": "Mailgun"},
|
|
|
|
{"cloud_provider": "Azure", "mail_service": "Mailjet"},
|
|
|
|
{"cloud_provider": "Azure", "mail_service": "Mandrill"},
|
|
|
|
{"cloud_provider": "Azure", "mail_service": "Postmark"},
|
|
|
|
{"cloud_provider": "Azure", "mail_service": "Sendgrid"},
|
|
|
|
{"cloud_provider": "Azure", "mail_service": "SendinBlue"},
|
|
|
|
{"cloud_provider": "Azure", "mail_service": "SparkPost"},
|
|
|
|
{"cloud_provider": "Azure", "mail_service": "Other SMTP"},
|
|
|
|
# Note: cloud_providers GCP, Azure, and None
|
|
|
|
# with mail_service Amazon SES is not supported
|
2020-03-24 22:53:45 +03:00
|
|
|
{"use_async": "y"},
|
|
|
|
{"use_async": "n"},
|
2020-02-29 20:15:35 +03:00
|
|
|
{"use_drf": "y"},
|
|
|
|
{"use_drf": "n"},
|
2022-03-20 18:00:40 +03:00
|
|
|
{"frontend_pipeline": "None"},
|
2022-06-13 22:17:46 +03:00
|
|
|
{"frontend_pipeline": "Django Compressor"},
|
2022-03-20 18:00:40 +03:00
|
|
|
{"frontend_pipeline": "Gulp"},
|
2023-01-29 15:12:12 +03:00
|
|
|
{"frontend_pipeline": "Webpack"},
|
2020-02-29 20:15:35 +03:00
|
|
|
{"use_celery": "y"},
|
|
|
|
{"use_celery": "n"},
|
|
|
|
{"use_mailhog": "y"},
|
|
|
|
{"use_mailhog": "n"},
|
|
|
|
{"use_sentry": "y"},
|
|
|
|
{"use_sentry": "n"},
|
|
|
|
{"use_whitenoise": "y"},
|
|
|
|
{"use_whitenoise": "n"},
|
|
|
|
{"use_heroku": "y"},
|
|
|
|
{"use_heroku": "n"},
|
|
|
|
{"ci_tool": "None"},
|
|
|
|
{"ci_tool": "Travis"},
|
|
|
|
{"ci_tool": "Gitlab"},
|
2020-09-21 13:20:24 +03:00
|
|
|
{"ci_tool": "Github"},
|
2020-02-29 20:15:35 +03:00
|
|
|
{"keep_local_envs_in_vcs": "y"},
|
|
|
|
{"keep_local_envs_in_vcs": "n"},
|
|
|
|
{"debug": "y"},
|
|
|
|
{"debug": "n"},
|
|
|
|
]
|
|
|
|
|
2020-03-14 20:29:08 +03:00
|
|
|
UNSUPPORTED_COMBINATIONS = [
|
|
|
|
{"cloud_provider": "None", "use_whitenoise": "n"},
|
2020-03-22 20:31:52 +03:00
|
|
|
{"cloud_provider": "GCP", "mail_service": "Amazon SES"},
|
2022-11-30 21:26:58 +03:00
|
|
|
{"cloud_provider": "Azure", "mail_service": "Amazon SES"},
|
2020-03-22 20:31:52 +03:00
|
|
|
{"cloud_provider": "None", "mail_service": "Amazon SES"},
|
2020-03-14 20:29:08 +03:00
|
|
|
]
|
2020-02-29 20:15:35 +03:00
|
|
|
|
|
|
|
|
|
|
|
def _fixture_id(ctx):
|
2021-12-16 14:07:47 +03:00
|
|
|
"""Helper to get a user-friendly test name from the parametrized context."""
|
2020-02-29 20:15:35 +03:00
|
|
|
return "-".join(f"{key}:{value}" for key, value in ctx.items())
|
2019-04-01 10:47:46 +03:00
|
|
|
|
|
|
|
|
2023-01-26 01:55:08 +03:00
|
|
|
def build_files_list(base_dir):
|
2015-11-09 01:46:38 +03:00
|
|
|
"""Build a list containing absolute paths to the generated files."""
|
2023-04-15 17:43:04 +03:00
|
|
|
return [os.path.join(dirpath, file_path) for dirpath, subdirs, files in os.walk(base_dir) for file_path in files]
|
2015-11-09 01:46:38 +03:00
|
|
|
|
2015-11-09 02:02:07 +03:00
|
|
|
|
2015-11-09 01:46:38 +03:00
|
|
|
def check_paths(paths):
|
2020-02-29 20:15:35 +03:00
|
|
|
"""Method to check all paths have correct substitutions."""
|
2015-11-09 01:46:38 +03:00
|
|
|
# Assert that no match is found in any of the files
|
|
|
|
for path in paths:
|
|
|
|
if is_binary(path):
|
|
|
|
continue
|
2018-04-09 01:03:29 +03:00
|
|
|
|
2022-05-07 21:21:15 +03:00
|
|
|
for line in open(path):
|
2015-11-09 01:46:38 +03:00
|
|
|
match = RE_OBJ.search(line)
|
2020-07-04 16:58:17 +03:00
|
|
|
assert match is None, f"cookiecutter variable not replaced in {path}"
|
2015-11-09 01:46:38 +03:00
|
|
|
|
|
|
|
|
2020-02-29 20:15:35 +03:00
|
|
|
@pytest.mark.parametrize("context_override", SUPPORTED_COMBINATIONS, ids=_fixture_id)
|
|
|
|
def test_project_generation(cookies, context, context_override):
|
|
|
|
"""Test that project is generated and fully rendered."""
|
2020-09-21 13:20:24 +03:00
|
|
|
|
2020-02-29 20:15:35 +03:00
|
|
|
result = cookies.bake(extra_context={**context, **context_override})
|
2015-11-09 01:05:32 +03:00
|
|
|
assert result.exit_code == 0
|
2015-11-09 01:46:38 +03:00
|
|
|
assert result.exception is None
|
2022-02-07 20:19:52 +03:00
|
|
|
assert result.project_path.name == context["project_slug"]
|
|
|
|
assert result.project_path.is_dir()
|
2015-11-09 01:46:38 +03:00
|
|
|
|
2022-02-07 20:19:52 +03:00
|
|
|
paths = build_files_list(str(result.project_path))
|
2015-11-09 01:46:38 +03:00
|
|
|
assert paths
|
|
|
|
check_paths(paths)
|
2015-11-09 01:59:10 +03:00
|
|
|
|
|
|
|
|
2020-02-29 20:15:35 +03:00
|
|
|
@pytest.mark.parametrize("context_override", SUPPORTED_COMBINATIONS, ids=_fixture_id)
|
|
|
|
def test_flake8_passes(cookies, context_override):
|
|
|
|
"""Generated project should pass flake8."""
|
|
|
|
result = cookies.bake(extra_context=context_override)
|
2015-11-09 02:02:07 +03:00
|
|
|
|
|
|
|
try:
|
2022-02-07 20:19:52 +03:00
|
|
|
sh.flake8(_cwd=str(result.project_path))
|
2015-11-09 02:02:07 +03:00
|
|
|
except sh.ErrorReturnCode as e:
|
2020-03-03 22:37:27 +03:00
|
|
|
pytest.fail(e.stdout.decode())
|
2019-05-15 14:37:17 +03:00
|
|
|
|
|
|
|
|
2023-04-28 10:56:22 +03:00
|
|
|
@auto_fixable
|
2020-02-29 20:15:35 +03:00
|
|
|
@pytest.mark.parametrize("context_override", SUPPORTED_COMBINATIONS, ids=_fixture_id)
|
|
|
|
def test_black_passes(cookies, context_override):
|
2023-04-15 15:21:18 +03:00
|
|
|
"""Check whether generated project passes black style."""
|
2020-02-29 20:15:35 +03:00
|
|
|
result = cookies.bake(extra_context=context_override)
|
2019-05-15 14:37:17 +03:00
|
|
|
|
2019-04-01 10:47:46 +03:00
|
|
|
try:
|
2020-05-12 12:24:25 +03:00
|
|
|
sh.black(
|
2022-02-07 18:40:53 +03:00
|
|
|
"--check",
|
|
|
|
"--diff",
|
|
|
|
"--exclude",
|
|
|
|
"migrations",
|
|
|
|
".",
|
2022-02-07 20:19:52 +03:00
|
|
|
_cwd=str(result.project_path),
|
2020-05-12 12:24:25 +03:00
|
|
|
)
|
2019-04-01 10:47:46 +03:00
|
|
|
except sh.ErrorReturnCode as e:
|
2020-03-03 22:37:27 +03:00
|
|
|
pytest.fail(e.stdout.decode())
|
2019-04-01 10:47:46 +03:00
|
|
|
|
Add missing `script` key to Travis CI config (#1950)
* Add failing test for travis.yml
I see three options to test travis.yml :
1. Testing that the YAML contains relevant value. Least useful and least
reliable, but simplest to implement.
2. Testing that the YAML is valid TravisCI YAML. Unfortunately this is
difficult / impossible. Doing 'travis lint' would succeed, this command
does not check for 'script' key presence and wouldn't be useful for us.
We could use 'travis-build' to verify that the YAML can be converted to
a worker config, but as of now 'travis-build' doesn't work out of the
box.
There is a new tool for validating travis YAML files 'travis-yml', but
as of now it's a ruby-only library and it's still a work in progress.
3. Running Travis CI task based on the generated YAML. This seems the
best approach, however since cookiecutter-django itself uses Travis CI,
that would require running Travis CI from within Travis CI.
Scheduling Travis CI job without a github push still requires a public
github repo, which is something that we can't generate on demand.
Given that I'm opting to use approach 1.
* Adds missing config to generated .travis.yml
The keys added are as follows:
1. 'script'
Required by Travis, cookiecutter-django used to provide it until it has
been removed together with hitch.
I'm assuming hitch has been replaced with pytest, I'm setting pytest as
the new value for the 'script' key.
2. 'install'
Not required by Travis, but necessary in our case; installs test
libraries, mostly pytest.
As of now this points to 'local.txt' requirements file. There used to be
a separate 'test.txt' requirements file but it has been decided to merge
it with 'local.txt', see discussion in
https://github.com/pydanny/cookiecutter-django/pull/1557 .
* Update CONTRIBUTORS.rst
2019-03-06 04:10:45 +03:00
|
|
|
|
2023-04-28 10:56:22 +03:00
|
|
|
@auto_fixable
|
2023-04-15 17:43:04 +03:00
|
|
|
@pytest.mark.parametrize("context_override", SUPPORTED_COMBINATIONS, ids=_fixture_id)
|
|
|
|
def test_isort_passes(cookies, context_override):
|
|
|
|
"""Check whether generated project passes isort style."""
|
|
|
|
result = cookies.bake(extra_context=context_override)
|
|
|
|
|
|
|
|
try:
|
|
|
|
sh.isort(_cwd=str(result.project_path))
|
|
|
|
except sh.ErrorReturnCode as e:
|
|
|
|
pytest.fail(e.stdout.decode())
|
|
|
|
|
|
|
|
|
2023-04-28 10:56:22 +03:00
|
|
|
@auto_fixable
|
|
|
|
@pytest.mark.parametrize("context_override", SUPPORTED_COMBINATIONS, ids=_fixture_id)
|
|
|
|
def test_django_upgrade_passes(cookies, context_override):
|
|
|
|
"""Check whether generated project passes django-upgrade."""
|
|
|
|
result = cookies.bake(extra_context=context_override)
|
|
|
|
|
|
|
|
python_files = [
|
|
|
|
file_path.removeprefix(f"{result.project_path}/")
|
|
|
|
for file_path in glob.glob(str(result.project_path / "**" / "*.py"), recursive=True)
|
|
|
|
]
|
|
|
|
try:
|
|
|
|
sh.django_upgrade(
|
|
|
|
"--target-version",
|
2023-06-28 09:38:04 +03:00
|
|
|
"4.2",
|
2023-04-28 10:56:22 +03:00
|
|
|
*python_files,
|
|
|
|
_cwd=str(result.project_path),
|
|
|
|
)
|
|
|
|
except sh.ErrorReturnCode as e:
|
|
|
|
pytest.fail(e.stdout.decode())
|
|
|
|
|
|
|
|
|
2023-06-28 00:52:36 +03:00
|
|
|
@pytest.mark.parametrize("context_override", SUPPORTED_COMBINATIONS, ids=_fixture_id)
|
|
|
|
def test_djlint_lint_passes(cookies, context_override):
|
|
|
|
"""Check whether generated project passes djLint --lint."""
|
|
|
|
result = cookies.bake(extra_context=context_override)
|
|
|
|
|
|
|
|
autofixable_rules = "H014,T001"
|
|
|
|
# TODO: remove T002 when fixed https://github.com/Riverside-Healthcare/djLint/issues/687
|
|
|
|
ignored_rules = "H006,H030,H031,T002"
|
|
|
|
try:
|
|
|
|
sh.djlint("--lint", "--ignore", f"{autofixable_rules},{ignored_rules}", ".", _cwd=str(result.project_path))
|
|
|
|
except sh.ErrorReturnCode as e:
|
|
|
|
pytest.fail(e.stdout.decode())
|
|
|
|
|
|
|
|
|
|
|
|
@auto_fixable
|
|
|
|
@pytest.mark.parametrize("context_override", SUPPORTED_COMBINATIONS, ids=_fixture_id)
|
|
|
|
def test_djlint_check_passes(cookies, context_override):
|
|
|
|
"""Check whether generated project passes djLint --check."""
|
|
|
|
result = cookies.bake(extra_context=context_override)
|
|
|
|
|
|
|
|
try:
|
|
|
|
sh.djlint("--check", ".", _cwd=str(result.project_path))
|
|
|
|
except sh.ErrorReturnCode as e:
|
|
|
|
pytest.fail(e.stdout.decode())
|
|
|
|
|
|
|
|
|
2020-04-16 20:34:12 +03:00
|
|
|
@pytest.mark.parametrize(
|
|
|
|
["use_docker", "expected_test_script"],
|
2020-08-27 10:41:28 +03:00
|
|
|
[
|
|
|
|
("n", "pytest"),
|
|
|
|
("y", "docker-compose -f local.yml run django pytest"),
|
|
|
|
],
|
2020-04-16 20:34:12 +03:00
|
|
|
)
|
|
|
|
def test_travis_invokes_pytest(cookies, context, use_docker, expected_test_script):
|
|
|
|
context.update({"ci_tool": "Travis", "use_docker": use_docker})
|
Add missing `script` key to Travis CI config (#1950)
* Add failing test for travis.yml
I see three options to test travis.yml :
1. Testing that the YAML contains relevant value. Least useful and least
reliable, but simplest to implement.
2. Testing that the YAML is valid TravisCI YAML. Unfortunately this is
difficult / impossible. Doing 'travis lint' would succeed, this command
does not check for 'script' key presence and wouldn't be useful for us.
We could use 'travis-build' to verify that the YAML can be converted to
a worker config, but as of now 'travis-build' doesn't work out of the
box.
There is a new tool for validating travis YAML files 'travis-yml', but
as of now it's a ruby-only library and it's still a work in progress.
3. Running Travis CI task based on the generated YAML. This seems the
best approach, however since cookiecutter-django itself uses Travis CI,
that would require running Travis CI from within Travis CI.
Scheduling Travis CI job without a github push still requires a public
github repo, which is something that we can't generate on demand.
Given that I'm opting to use approach 1.
* Adds missing config to generated .travis.yml
The keys added are as follows:
1. 'script'
Required by Travis, cookiecutter-django used to provide it until it has
been removed together with hitch.
I'm assuming hitch has been replaced with pytest, I'm setting pytest as
the new value for the 'script' key.
2. 'install'
Not required by Travis, but necessary in our case; installs test
libraries, mostly pytest.
As of now this points to 'local.txt' requirements file. There used to be
a separate 'test.txt' requirements file but it has been decided to merge
it with 'local.txt', see discussion in
https://github.com/pydanny/cookiecutter-django/pull/1557 .
* Update CONTRIBUTORS.rst
2019-03-06 04:10:45 +03:00
|
|
|
result = cookies.bake(extra_context=context)
|
|
|
|
|
|
|
|
assert result.exit_code == 0
|
|
|
|
assert result.exception is None
|
2022-02-07 20:19:52 +03:00
|
|
|
assert result.project_path.name == context["project_slug"]
|
|
|
|
assert result.project_path.is_dir()
|
Add missing `script` key to Travis CI config (#1950)
* Add failing test for travis.yml
I see three options to test travis.yml :
1. Testing that the YAML contains relevant value. Least useful and least
reliable, but simplest to implement.
2. Testing that the YAML is valid TravisCI YAML. Unfortunately this is
difficult / impossible. Doing 'travis lint' would succeed, this command
does not check for 'script' key presence and wouldn't be useful for us.
We could use 'travis-build' to verify that the YAML can be converted to
a worker config, but as of now 'travis-build' doesn't work out of the
box.
There is a new tool for validating travis YAML files 'travis-yml', but
as of now it's a ruby-only library and it's still a work in progress.
3. Running Travis CI task based on the generated YAML. This seems the
best approach, however since cookiecutter-django itself uses Travis CI,
that would require running Travis CI from within Travis CI.
Scheduling Travis CI job without a github push still requires a public
github repo, which is something that we can't generate on demand.
Given that I'm opting to use approach 1.
* Adds missing config to generated .travis.yml
The keys added are as follows:
1. 'script'
Required by Travis, cookiecutter-django used to provide it until it has
been removed together with hitch.
I'm assuming hitch has been replaced with pytest, I'm setting pytest as
the new value for the 'script' key.
2. 'install'
Not required by Travis, but necessary in our case; installs test
libraries, mostly pytest.
As of now this points to 'local.txt' requirements file. There used to be
a separate 'test.txt' requirements file but it has been decided to merge
it with 'local.txt', see discussion in
https://github.com/pydanny/cookiecutter-django/pull/1557 .
* Update CONTRIBUTORS.rst
2019-03-06 04:10:45 +03:00
|
|
|
|
2022-05-07 21:21:15 +03:00
|
|
|
with open(f"{result.project_path}/.travis.yml") as travis_yml:
|
Add missing `script` key to Travis CI config (#1950)
* Add failing test for travis.yml
I see three options to test travis.yml :
1. Testing that the YAML contains relevant value. Least useful and least
reliable, but simplest to implement.
2. Testing that the YAML is valid TravisCI YAML. Unfortunately this is
difficult / impossible. Doing 'travis lint' would succeed, this command
does not check for 'script' key presence and wouldn't be useful for us.
We could use 'travis-build' to verify that the YAML can be converted to
a worker config, but as of now 'travis-build' doesn't work out of the
box.
There is a new tool for validating travis YAML files 'travis-yml', but
as of now it's a ruby-only library and it's still a work in progress.
3. Running Travis CI task based on the generated YAML. This seems the
best approach, however since cookiecutter-django itself uses Travis CI,
that would require running Travis CI from within Travis CI.
Scheduling Travis CI job without a github push still requires a public
github repo, which is something that we can't generate on demand.
Given that I'm opting to use approach 1.
* Adds missing config to generated .travis.yml
The keys added are as follows:
1. 'script'
Required by Travis, cookiecutter-django used to provide it until it has
been removed together with hitch.
I'm assuming hitch has been replaced with pytest, I'm setting pytest as
the new value for the 'script' key.
2. 'install'
Not required by Travis, but necessary in our case; installs test
libraries, mostly pytest.
As of now this points to 'local.txt' requirements file. There used to be
a separate 'test.txt' requirements file but it has been decided to merge
it with 'local.txt', see discussion in
https://github.com/pydanny/cookiecutter-django/pull/1557 .
* Update CONTRIBUTORS.rst
2019-03-06 04:10:45 +03:00
|
|
|
try:
|
2020-07-04 16:58:17 +03:00
|
|
|
yml = yaml.safe_load(travis_yml)["jobs"]["include"]
|
2020-04-14 18:52:14 +03:00
|
|
|
assert yml[0]["script"] == ["flake8"]
|
2020-04-16 20:34:12 +03:00
|
|
|
assert yml[1]["script"] == [expected_test_script]
|
Add missing `script` key to Travis CI config (#1950)
* Add failing test for travis.yml
I see three options to test travis.yml :
1. Testing that the YAML contains relevant value. Least useful and least
reliable, but simplest to implement.
2. Testing that the YAML is valid TravisCI YAML. Unfortunately this is
difficult / impossible. Doing 'travis lint' would succeed, this command
does not check for 'script' key presence and wouldn't be useful for us.
We could use 'travis-build' to verify that the YAML can be converted to
a worker config, but as of now 'travis-build' doesn't work out of the
box.
There is a new tool for validating travis YAML files 'travis-yml', but
as of now it's a ruby-only library and it's still a work in progress.
3. Running Travis CI task based on the generated YAML. This seems the
best approach, however since cookiecutter-django itself uses Travis CI,
that would require running Travis CI from within Travis CI.
Scheduling Travis CI job without a github push still requires a public
github repo, which is something that we can't generate on demand.
Given that I'm opting to use approach 1.
* Adds missing config to generated .travis.yml
The keys added are as follows:
1. 'script'
Required by Travis, cookiecutter-django used to provide it until it has
been removed together with hitch.
I'm assuming hitch has been replaced with pytest, I'm setting pytest as
the new value for the 'script' key.
2. 'install'
Not required by Travis, but necessary in our case; installs test
libraries, mostly pytest.
As of now this points to 'local.txt' requirements file. There used to be
a separate 'test.txt' requirements file but it has been decided to merge
it with 'local.txt', see discussion in
https://github.com/pydanny/cookiecutter-django/pull/1557 .
* Update CONTRIBUTORS.rst
2019-03-06 04:10:45 +03:00
|
|
|
except yaml.YAMLError as e:
|
2020-04-16 20:34:12 +03:00
|
|
|
pytest.fail(str(e))
|
2019-06-05 21:00:43 +03:00
|
|
|
|
|
|
|
|
2020-04-16 20:34:12 +03:00
|
|
|
@pytest.mark.parametrize(
|
|
|
|
["use_docker", "expected_test_script"],
|
2020-08-27 10:41:28 +03:00
|
|
|
[
|
|
|
|
("n", "pytest"),
|
|
|
|
("y", "docker-compose -f local.yml run django pytest"),
|
|
|
|
],
|
2020-04-16 20:34:12 +03:00
|
|
|
)
|
2023-04-15 17:43:04 +03:00
|
|
|
def test_gitlab_invokes_precommit_and_pytest(cookies, context, use_docker, expected_test_script):
|
2020-04-16 20:34:12 +03:00
|
|
|
context.update({"ci_tool": "Gitlab", "use_docker": use_docker})
|
2019-12-06 10:55:00 +03:00
|
|
|
result = cookies.bake(extra_context=context)
|
|
|
|
|
|
|
|
assert result.exit_code == 0
|
|
|
|
assert result.exception is None
|
2022-02-07 20:19:52 +03:00
|
|
|
assert result.project_path.name == context["project_slug"]
|
|
|
|
assert result.project_path.is_dir()
|
2019-12-06 10:55:00 +03:00
|
|
|
|
2022-05-07 21:21:15 +03:00
|
|
|
with open(f"{result.project_path}/.gitlab-ci.yml") as gitlab_yml:
|
2019-12-06 10:55:00 +03:00
|
|
|
try:
|
2020-07-04 16:58:17 +03:00
|
|
|
gitlab_config = yaml.safe_load(gitlab_yml)
|
2023-02-25 15:33:30 +03:00
|
|
|
assert gitlab_config["precommit"]["script"] == [
|
|
|
|
"pre-commit run --show-diff-on-failure --color=always --all-files"
|
|
|
|
]
|
2020-04-16 20:34:12 +03:00
|
|
|
assert gitlab_config["pytest"]["script"] == [expected_test_script]
|
2019-12-06 10:55:00 +03:00
|
|
|
except yaml.YAMLError as e:
|
|
|
|
pytest.fail(e)
|
|
|
|
|
|
|
|
|
2020-09-21 13:20:24 +03:00
|
|
|
@pytest.mark.parametrize(
|
|
|
|
["use_docker", "expected_test_script"],
|
|
|
|
[
|
|
|
|
("n", "pytest"),
|
2021-03-03 00:20:20 +03:00
|
|
|
("y", "docker-compose -f local.yml run django pytest"),
|
2020-09-21 13:20:24 +03:00
|
|
|
],
|
|
|
|
)
|
2023-04-15 17:43:04 +03:00
|
|
|
def test_github_invokes_linter_and_pytest(cookies, context, use_docker, expected_test_script):
|
2020-09-21 13:20:24 +03:00
|
|
|
context.update({"ci_tool": "Github", "use_docker": use_docker})
|
|
|
|
result = cookies.bake(extra_context=context)
|
|
|
|
|
|
|
|
assert result.exit_code == 0
|
|
|
|
assert result.exception is None
|
2022-02-07 20:19:52 +03:00
|
|
|
assert result.project_path.name == context["project_slug"]
|
|
|
|
assert result.project_path.is_dir()
|
2020-09-21 13:20:24 +03:00
|
|
|
|
2022-05-07 21:21:15 +03:00
|
|
|
with open(f"{result.project_path}/.github/workflows/ci.yml") as github_yml:
|
2020-09-21 13:20:24 +03:00
|
|
|
try:
|
|
|
|
github_config = yaml.safe_load(github_yml)
|
2021-02-23 08:41:03 +03:00
|
|
|
linter_present = False
|
|
|
|
for action_step in github_config["jobs"]["linter"]["steps"]:
|
2021-02-23 08:58:37 +03:00
|
|
|
if action_step.get("uses", "NA").startswith("pre-commit"):
|
2021-02-23 08:41:03 +03:00
|
|
|
linter_present = True
|
|
|
|
assert linter_present
|
2020-09-21 13:20:24 +03:00
|
|
|
|
|
|
|
expected_test_script_present = False
|
|
|
|
for action_step in github_config["jobs"]["pytest"]["steps"]:
|
|
|
|
if action_step.get("run") == expected_test_script:
|
|
|
|
expected_test_script_present = True
|
|
|
|
assert expected_test_script_present
|
|
|
|
except yaml.YAMLError as e:
|
|
|
|
pytest.fail(e)
|
|
|
|
|
|
|
|
|
2019-06-05 21:00:43 +03:00
|
|
|
@pytest.mark.parametrize("slug", ["project slug", "Project_Slug"])
|
|
|
|
def test_invalid_slug(cookies, context, slug):
|
2021-12-16 14:07:47 +03:00
|
|
|
"""Invalid slug should fail pre-generation hook."""
|
2019-06-05 21:00:43 +03:00
|
|
|
context.update({"project_slug": slug})
|
|
|
|
|
|
|
|
result = cookies.bake(extra_context=context)
|
|
|
|
|
|
|
|
assert result.exit_code != 0
|
|
|
|
assert isinstance(result.exception, FailedHookException)
|
2019-10-02 18:03:33 +03:00
|
|
|
|
|
|
|
|
2020-02-29 20:15:35 +03:00
|
|
|
@pytest.mark.parametrize("invalid_context", UNSUPPORTED_COMBINATIONS)
|
|
|
|
def test_error_if_incompatible(cookies, context, invalid_context):
|
|
|
|
"""It should not generate project an incompatible combination is selected."""
|
|
|
|
context.update(invalid_context)
|
2020-02-07 05:03:49 +03:00
|
|
|
result = cookies.bake(extra_context=context)
|
|
|
|
|
|
|
|
assert result.exit_code != 0
|
|
|
|
assert isinstance(result.exception, FailedHookException)
|
2021-04-26 14:17:02 +03:00
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize(
|
2023-07-03 12:55:33 +03:00
|
|
|
["editor", "pycharm_docs_exist"],
|
2021-04-26 14:17:02 +03:00
|
|
|
[
|
2023-07-03 12:55:33 +03:00
|
|
|
("None", False),
|
|
|
|
("PyCharm", True),
|
|
|
|
("VS Code", False),
|
2021-04-26 14:17:02 +03:00
|
|
|
],
|
|
|
|
)
|
2023-07-03 12:55:33 +03:00
|
|
|
def test_pycharm_docs_removed(cookies, context, editor, pycharm_docs_exist):
|
|
|
|
context.update({"editor": editor})
|
2021-04-26 14:17:02 +03:00
|
|
|
result = cookies.bake(extra_context=context)
|
|
|
|
|
2022-05-07 21:21:15 +03:00
|
|
|
with open(f"{result.project_path}/docs/index.rst") as f:
|
2021-04-27 13:41:00 +03:00
|
|
|
has_pycharm_docs = "pycharm/configuration" in f.read()
|
2021-09-11 19:48:47 +03:00
|
|
|
assert has_pycharm_docs is pycharm_docs_exist
|
2023-03-16 20:17:02 +03:00
|
|
|
|
|
|
|
|
|
|
|
def test_trim_domain_email(cookies, context):
|
|
|
|
"""Check that leading and trailing spaces are trimmed in domain and email."""
|
|
|
|
context.update(
|
|
|
|
{
|
|
|
|
"use_docker": "y",
|
|
|
|
"domain_name": " example.com ",
|
|
|
|
"email": " me@example.com ",
|
|
|
|
}
|
|
|
|
)
|
|
|
|
result = cookies.bake(extra_context=context)
|
|
|
|
|
|
|
|
assert result.exit_code == 0
|
|
|
|
|
|
|
|
prod_django_env = result.project_path / ".envs" / ".production" / ".django"
|
|
|
|
assert "DJANGO_ALLOWED_HOSTS=.example.com" in prod_django_env.read_text()
|
|
|
|
|
|
|
|
base_settings = result.project_path / "config" / "settings" / "base.py"
|
|
|
|
assert '"me@example.com"' in base_settings.read_text()
|