mirror of
https://github.com/cookiecutter/cookiecutter-django.git
synced 2024-11-14 05:36:58 +03:00
Avoid '$' in random string generation
Until the [upstream bug](https://github.com/joke2k/django-environ/issues/60) is fixed in django-environ, this should prevent people using this template from hitting the bug. Fix #454
This commit is contained in:
parent
f4cfe6c704
commit
11bb4cdb84
|
@ -118,9 +118,11 @@ def generate_random_string(
|
||||||
if using_ascii_letters:
|
if using_ascii_letters:
|
||||||
symbols += string.ascii_letters
|
symbols += string.ascii_letters
|
||||||
if using_punctuation:
|
if using_punctuation:
|
||||||
symbols += string.punctuation.replace('"', "").replace("'", "").replace(
|
all_punctuation = set(string.punctuation)
|
||||||
"\\", ""
|
# These symbols can cause issues in environment variables
|
||||||
)
|
unsuitable = {"'", '"', "\\", "$"}
|
||||||
|
suitable = all_punctuation.difference(unsuitable)
|
||||||
|
symbols += "".join(suitable)
|
||||||
return "".join([random.choice(symbols) for _ in range(length)])
|
return "".join([random.choice(symbols) for _ in range(length)])
|
||||||
|
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user