mirror of
				https://github.com/cookiecutter/cookiecutter-django.git
				synced 2025-10-31 16:07:49 +03:00 
			
		
		
		
	Merge pull request #1717 from hendrikschneider/master
removed default action from project.js #1716
This commit is contained in:
		
						commit
						95ee1f159d
					
				|  | @ -99,6 +99,7 @@ Listed in alphabetical order. | |||
|   Garry Polley             `@garrypolley`_ | ||||
|   Hamish Durkin            `@durkode`_ | ||||
|   Harry Percival           `@hjwp`_ | ||||
|   Hendrik Schneider        `@hendrikschneider`_ | ||||
|   Henrique G. G. Pereira   `@ikkebr`_ | ||||
|   Ian Lee                  `@IanLee1521`_ | ||||
|   Jan Van Bruggen          `@jvanbrug`_ | ||||
|  | @ -210,6 +211,7 @@ Listed in alphabetical order. | |||
| .. _@goldhand: https://github.com/goldhand | ||||
| .. _@hackebrot: https://github.com/hackebrot | ||||
| .. _@hairychris: https://github.com/hairychris | ||||
| .. _@hendrikschneider https://github.com/hendrikschneider | ||||
| .. _@hjwp: https://github.com/hjwp | ||||
| .. _@IanLee1521: https://github.com/IanLee1521 | ||||
| .. _@ikkebr: https://github.com/ikkebr | ||||
|  |  | |||
|  | @ -1,21 +1 @@ | |||
| /* Project specific Javascript goes here. */ | ||||
| 
 | ||||
| /* | ||||
| Formatting hack to get around crispy-forms unfortunate hardcoding | ||||
| in helpers.FormHelper: | ||||
| 
 | ||||
|     if template_pack == 'bootstrap4': | ||||
|         grid_colum_matcher = re.compile('\w*col-(xs|sm|md|lg|xl)-\d+\w*') | ||||
|         using_grid_layout = (grid_colum_matcher.match(self.label_class) or | ||||
|                              grid_colum_matcher.match(self.field_class)) | ||||
|         if using_grid_layout: | ||||
|             items['using_grid_layout'] = True | ||||
| 
 | ||||
| Issues with the above approach: | ||||
| 
 | ||||
| 1. Fragile: Assumes Bootstrap 4's API doesn't change (it does) | ||||
| 2. Unforgiving: Doesn't allow for any variation in template design | ||||
| 3. Really Unforgiving: No way to override this behavior | ||||
| 4. Undocumented: No mention in the documentation, or it's too hard for me to find | ||||
| */ | ||||
| $('.form-group').removeClass('row'); | ||||
|  |  | |||
		Loading…
	
		Reference in New Issue
	
	Block a user