cookiecutter/cookiecutter-django
1
1
Fork 0
mirror of https://github.com/cookiecutter/cookiecutter-django.git synced 2025-02-04 13:40:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

Updated test_urls and views to re-use User.get_absolute_url method instead of using reverse on the user:detail view

Browse Source
This commit is contained in:
Arnav Choudhury 2021-02-26 12:04:48 +05:30
parent e0566e5b1e
commit fa0b278225
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
{{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/users/tests/test_urls.py
View File

@ -7,10 +7,7 @@ pytestmark = pytest.mark.django_db
def test_detail(user: User):
assert (
reverse("users:detail", kwargs={"username": user.username})
== f"/users/{user.username}/"
)
assert user.get_absolute_url() == f"/users/{user.username}/"
assert resolve(f"/users/{user.username}/").view_name == "users:detail"

2
{{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/users/views.py
View File

@ -25,7 +25,7 @@ class UserUpdateView(LoginRequiredMixin, SuccessMessageMixin, UpdateView):
success_message = _("Information successfully updated")
def get_success_url(self):
return reverse("users:detail", kwargs={"username": self.request.user.username})
return self.request.user.get_absolute_url() # type: ignore [union-attr]
def get_object(self):
return self.request.user