curl/curl
1
1
Fork 0
mirror of https://github.com/curl/curl.git synced 2025-09-09 13:49:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

doh: reduce the DNS request buffer size

Browse Source 
No point in having it larger than the largest allowed request size.

Also removed a no longer used struct.

Closes #17087
This commit is contained in:
Daniel Stenberg 2025-04-17 17:54:59 +02:00
parent d6c8907864
commit 834836dc14
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/doh.c
View File

@ -115,7 +115,7 @@ UNITTEST DOHcode doh_req_encode(const char *host,
if(host[hostlen-1]!='.') if(host[hostlen-1]!='.')
expected_len++; expected_len++;
if(expected_len > (256 + 16)) /* RFCs 1034, 1035 */ if(expected_len > DOH_MAX_DNSREQ_SIZE)
return DOH_DNS_NAME_TOO_LONG; return DOH_DNS_NAME_TOO_LONG;
if(len < expected_len) if(len < expected_len)

14
lib/doh.h
View File

@ -59,15 +59,6 @@ typedef enum {
DNS_TYPE_HTTPS = 65 DNS_TYPE_HTTPS = 65
} DNStype; } DNStype;
/* one of these for each DoH request */
struct doh_probe {
unsigned int easy_mid; /* multi id of easy handle doing the lookup */
DNStype dnstype;
unsigned char req_body[512];
size_t req_body_len;
struct dynbuf resp_body;
};
enum doh_slot_num { enum doh_slot_num {
/* Explicit values for first two symbols so as to match hard-coded /* Explicit values for first two symbols so as to match hard-coded
* constants in existing code * constants in existing code
@ -91,13 +82,16 @@ enum doh_slot_num {
#define CURL_EZM_DOH_PROBE "ezm:doh-p" #define CURL_EZM_DOH_PROBE "ezm:doh-p"
/* the largest one we can make, based on RFCs 1034, 1035 */
#define DOH_MAX_DNSREQ_SIZE (256 + 16)
/* each DoH probe request has this /* each DoH probe request has this
* as easy meta for CURL_EZM_DOH_PROBE */ * as easy meta for CURL_EZM_DOH_PROBE */
struct doh_request { struct doh_request {
unsigned char req_body[DOH_MAX_DNSREQ_SIZE];
struct curl_slist *req_hds; struct curl_slist *req_hds;
struct dynbuf resp_body; struct dynbuf resp_body;
size_t req_body_len; size_t req_body_len;
unsigned char req_body[512];
DNStype dnstype; DNStype dnstype;
}; };