curl/curl
1
1
Fork 0
mirror of https://github.com/curl/curl.git synced 2025-09-20 11:02:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

connectionexists: use case sensitive user/password comparisons

Browse Source 
CVE-2016-8616

Bug: https://curl.haxx.se/docs/adv_20161102B.html
Reported-by: Cure53
This commit is contained in:
Daniel Stenberg 2016-09-27 18:01:53 +02:00
parent efd24d5742
commit b3ee26c5df
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/url.c
View File

@ -3394,8 +3394,8 @@ ConnectionExists(struct Curl_easy *data,
if(!(needle->handler->flags & PROTOPT_CREDSPERREQUEST)) { if(!(needle->handler->flags & PROTOPT_CREDSPERREQUEST)) {
/* This protocol requires credentials per connection, /* This protocol requires credentials per connection,
so verify that we're using the same name and password as well */ so verify that we're using the same name and password as well */
if(!strequal(needle->user, check->user) || if(strcmp(needle->user, check->user) ||
!strequal(needle->passwd, check->passwd)) { strcmp(needle->passwd, check->passwd)) {
/* one of them was different */ /* one of them was different */
continue; continue;
} }
@ -3455,8 +3455,8 @@ ConnectionExists(struct Curl_easy *data,
possible. (Especially we must not reuse the same connection if possible. (Especially we must not reuse the same connection if
partway through a handshake!) */ partway through a handshake!) */
if(wantNTLMhttp) { if(wantNTLMhttp) {
if(!strequal(needle->user, check->user) || if(strcmp(needle->user, check->user) ||
!strequal(needle->passwd, check->passwd)) strcmp(needle->passwd, check->passwd))
continue; continue;
} }
else if(check->ntlm.state != NTLMSTATE_NONE) { else if(check->ntlm.state != NTLMSTATE_NONE) {
@ -3470,8 +3470,8 @@ ConnectionExists(struct Curl_easy *data,
if(!check->proxyuser || !check->proxypasswd) if(!check->proxyuser || !check->proxypasswd)
continue; continue;
if(!strequal(needle->proxyuser, check->proxyuser) || if(strcmp(needle->proxyuser, check->proxyuser) ||
!strequal(needle->proxypasswd, check->proxypasswd)) strcmp(needle->proxypasswd, check->proxypasswd))
continue; continue;
} }
else if(check->proxyntlm.state != NTLMSTATE_NONE) { else if(check->proxyntlm.state != NTLMSTATE_NONE) {