django/daphne
1
1
Fork 0
mirror of https://github.com/django/daphne.git synced 2025-07-14 09:52:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Found a bug whereby streaming responses would try to be cached (#396)

Browse Source 
entirely in memory. Was causing views that stream a lot of data
to timeout.
This commit is contained in:
Luke Hodkinson 2016-10-12 16:32:45 +11:00 committed by Andrew Godwin
parent c419d01ded
commit 1673be5b75
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
channels/handler.py
View File

@ -340,7 +340,9 @@ class ViewConsumer(object):
# a whole worker if the client just vanishes and leaves the response # a whole worker if the client just vanishes and leaves the response
# channel full. # channel full.
try: try:
message.reply_channel.send(reply_message) # Note: Use immediately to prevent streaming responses trying
# cache all data.
message.reply_channel.send(reply_message, immediately=True)
except message.channel_layer.ChannelFull: except message.channel_layer.ChannelFull:
time.sleep(0.05) time.sleep(0.05)
else: else: