django/daphne
1
1
Fork 0
mirror of https://github.com/django/daphne.git synced 2024-11-28 02:33:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Avoid Twisted using the default event loop

Browse Source 
When switching threads, e.g. when run via Django auto-reloader, the default run loop causes issues detecting async contexts.
Fixes https://github.com/django/channels/issues/1374
This commit is contained in:
Carlton Gibson 2019-12-18 20:05:50 +01:00 committed by Carlton Gibson
parent eb582d1d43
commit 27f760a814
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
daphne/server.py
View File

@ -1,8 +1,10 @@
# This has to be done first as Twisted is import-order-sensitive with reactors # This has to be done first as Twisted is import-order-sensitive with reactors
import asyncio # isort:skip
import sys # isort:skip import sys # isort:skip
import warnings # isort:skip import warnings # isort:skip
from twisted.internet import asyncioreactor # isort:skip from twisted.internet import asyncioreactor # isort:skip
twisted_loop = asyncio.new_event_loop()
current_reactor = sys.modules.get("twisted.internet.reactor", None) current_reactor = sys.modules.get("twisted.internet.reactor", None)
if current_reactor is not None: if current_reactor is not None:
if not isinstance(current_reactor, asyncioreactor.AsyncioSelectorReactor): if not isinstance(current_reactor, asyncioreactor.AsyncioSelectorReactor):
@ -13,11 +15,10 @@ if current_reactor is not None:
UserWarning, UserWarning,
) )
del sys.modules["twisted.internet.reactor"] del sys.modules["twisted.internet.reactor"]
asyncioreactor.install() asyncioreactor.install(twisted_loop)
else: else:
asyncioreactor.install() asyncioreactor.install(twisted_loop)
import asyncio
import logging import logging
import time import time
import traceback import traceback