django/daphne
1
1
Fork 0
mirror of https://github.com/django/daphne.git synced 2025-11-04 01:27:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fixed #28: Logging breaking bad WebSocket error messages

Browse Source
This commit is contained in:
Andrew Godwin 2016-06-27 16:41:48 -07:00
parent da3cce79d0
commit 6679b8dfdf
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
daphne/http_protocol.py
View File

@ -104,7 +104,10 @@ class WebRequest(http.Request):
data += self.content.read()
protocol.dataReceived(data)
# Remove our HTTP reply channel association
logger.debug("Upgraded connection %s to WebSocket %s", self.reply_channel, protocol.reply_channel)
if hasattr(protocol, "reply_channel"):
logger.debug("Upgraded connection %s to WebSocket %s", self.reply_channel, protocol.reply_channel)
else:
logger.debug("Connection %s did not get successful WS handshake.", self.reply_channel)
del self.factory.reply_protocols[self.reply_channel]
self.reply_channel = None
# Boring old HTTP.