django/daphne
1
1
Fork 0
mirror of https://github.com/django/daphne.git synced 2025-10-30 23:37:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Intepret + in query string section as a space

Browse Source
This commit is contained in:
Andrew Godwin 2016-06-21 07:56:34 -07:00
parent 734fd8dbd3
commit 66e005f277
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
daphne/http_protocol.py
View File

@ -5,7 +5,7 @@ import six
import time import time
import traceback import traceback
from six.moves.urllib_parse import unquote from six.moves.urllib_parse import unquote, unquote_plus
from twisted.protocols.policies import ProtocolWrapper from twisted.protocols.policies import ProtocolWrapper
from twisted.web import http from twisted.web import http
@ -128,7 +128,7 @@ class WebRequest(http.Request):
"method": self.method.decode("ascii"), "method": self.method.decode("ascii"),
"path": self.unquote(self.path), "path": self.unquote(self.path),
"scheme": "http", "scheme": "http",
"query_string": self.unquote(self.query_string), "query_string": self.unquote(self.query_string, plus_as_space=True),
"headers": self.clean_headers, "headers": self.clean_headers,
"body": self.content.read(), "body": self.content.read(),
"client": self.client_addr, "client": self.client_addr,
@ -142,12 +142,18 @@ class WebRequest(http.Request):
self.basic_error(500, b"Internal Server Error", "HTTP processing error") self.basic_error(500, b"Internal Server Error", "HTTP processing error")
@classmethod @classmethod
def unquote(cls, value): def unquote(cls, value, plus_as_space=False):
""" """
Python 2 and 3 compat layer for utf-8 unquoting Python 2 and 3 compat layer for utf-8 unquoting
""" """
if six.PY2: if six.PY2:
if plus_as_space:
return unquote_plus(value).decode("utf8")
else:
return unquote(value).decode("utf8") return unquote(value).decode("utf8")
else:
if plus_as_space:
return unquote_plus(value.decode("ascii"))
else: else:
return unquote(value.decode("ascii")) return unquote(value.decode("ascii"))