From 8787c1dfe2592135e221c355204b405068de8db7 Mon Sep 17 00:00:00 2001 From: Maik Hoepfel Date: Tue, 2 May 2017 19:23:49 +0200 Subject: [PATCH] Check query string for spec conformance again (#112) This check was skipped because of https://github.com/django/daphne/issues/110. As this issue is now fixed, we can re-enable the check again. --- daphne/tests/testcases.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/daphne/tests/testcases.py b/daphne/tests/testcases.py index 9e78795..55af5be 100644 --- a/daphne/tests/testcases.py +++ b/daphne/tests/testcases.py @@ -223,11 +223,8 @@ class ASGIWebSocketTestCase(ASGITestCaseBase): query_string = channel_message.get('query_string') if query_string: # Assert that query_string is a byte string and still url encoded - # TODO: It's neither a byte string nor urlencoded - # Will fail until https://github.com/django/daphne/issues/110 is resolved. - #self.assertIsInstance(query_string, six.binary_type) - #self.assertEqual(query_string, parse.urlencode(request_params or []).encode('ascii')) - pass + self.assertIsInstance(query_string, six.binary_type) + self.assertEqual(query_string, parse.urlencode(request_params or []).encode('ascii')) root_path = channel_message.get('root_path') if root_path is not None: