django/daphne
1
1
Fork 0
mirror of https://github.com/django/daphne.git synced 2025-06-07 06:33:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

Shuffle fetch order for channels to prevent starvation

Browse Source
This commit is contained in:
Andrew Godwin 2015-11-06 13:33:51 +01:00
parent aaf2321db1
commit b9f07475b7
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
channels/backends/redis_py.py
View File

@ -56,6 +56,8 @@ class RedisChannelBackend(BaseChannelBackend):
def receive_many(self, channels): def receive_many(self, channels):
if not channels: if not channels:
raise ValueError("Cannot receive on empty channel list!") raise ValueError("Cannot receive on empty channel list!")
# Shuffle channels to avoid the first ones starving others of workers
random.shuffle(channels)
# Get a message from one of our channels # Get a message from one of our channels
while True: while True:
result = self.connection.blpop([self.prefix + channel for channel in channels], timeout=1) result = self.connection.blpop([self.prefix + channel for channel in channels], timeout=1)