django/daphne
1
1
Fork 0
mirror of https://github.com/django/daphne.git synced 2025-04-20 16:52:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix type for request.META['SERVER_PORT'] (#378)

Browse Source 
Django documentation states that it is a string.
Fixes #366
This commit is contained in:
Carles Barrobés 2016-09-23 20:37:45 +02:00 committed by Andrew Godwin
parent eaaf70e935
commit d4f7125cd5
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
channels/handler.py
View File

@ -66,7 +66,7 @@ class AsgiRequest(http.HttpRequest):
self.META['REMOTE_PORT'] = self.message['client'][1]
if self.message.get('server', None):
self.META['SERVER_NAME'] = self.message['server'][0]
self.META['SERVER_PORT'] = self.message['server'][1]
self.META['SERVER_PORT'] = six.text_type(self.message['server'][1])
# Handle old style-headers for a transition period
if "headers" in self.message and isinstance(self.message['headers'], dict):
self.message['headers'] = [

2
channels/tests/test_request.py
View File

@ -63,7 +63,7 @@ class RequestTests(ChannelTestCase):
self.assertEqual(request.META["REMOTE_HOST"], "10.0.0.1")
self.assertEqual(request.META["REMOTE_PORT"], 1234)
self.assertEqual(request.META["SERVER_NAME"], "10.0.0.2")
self.assertEqual(request.META["SERVER_PORT"], 80)
self.assertEqual(request.META["SERVER_PORT"], "80")
self.assertEqual(request.GET["x"], "1")
self.assertEqual(request.GET["y"], "&foo bar+baz")
self.assertEqual(request.COOKIES["test-time"], "1448995585123")