django/daphne
1
1
Fork 0
mirror of https://github.com/django/daphne.git synced 2025-04-20 00:32:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

Only force a default endpoint w/o valid endpoint

Browse Source 
If you run `daphne --endpoint ssl:8000:privateKey=key.pem:certKey=cert.pem --bind 0.0.0.0  MyApp.asgi:application` in trying to specify that the application should bind to 0.0.0.0, two bindings will be made to the same port, and daphne will never properly start. While I know the `--bind 0.0.0.0` specification is unnecessary, it's certainly confusing to debug and is not intuitive from the standpoint of the programmer trying to use the CLI.
This commit is contained in:
fitzgeralddp 2021-01-16 22:07:35 -05:00 committed by GitHub
parent aac4708a61
commit e8d371cb67
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
daphne/cli.py
View File

@ -245,10 +245,18 @@ class CommandLineInterface(object):
# no advanced binding options passed, patch in defaults
args.host = DEFAULT_HOST
args.port = DEFAULT_PORT
elif args.host and args.port is None:
elif args.host and args.port is None and not any([
# Checking the other options must be done or else
args.unix_socket,
args.file_descriptor is not None,
args.socket_strings
]):
args.port = DEFAULT_PORT
elif args.port is not None and not args.host:
args.host = DEFAULT_HOST
elif args.port is not None and not args.host and not any([
args.unix_socket,
args.file_descriptor is not None,
args.socket_strings
]):
# Build endpoint description strings from (optional) cli arguments
endpoints = build_endpoint_description_strings(
host=args.host,