django/django
1
1
Fork 0
mirror of https://github.com/django/django.git synced 2025-09-09 21:52:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

Removed @skipIfDBFeature silencing of nonexistent features.

Browse Source 
Follow up to f5df7ed7e6.
This commit is contained in:
Tim Graham 2025-06-21 08:51:34 -04:00 committed by GitHub
parent f5df7ed7e6
commit 54402a7529
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
django/test/testcases.py
View File

@ -1582,9 +1582,7 @@ def _deferredSkip(condition, reason, name):
def skipIfDBFeature(*features): def skipIfDBFeature(*features):
"""Skip a test if a database has at least one of the named features.""" """Skip a test if a database has at least one of the named features."""
return _deferredSkip( return _deferredSkip(
lambda: any( lambda: any(getattr(connection.features, feature) for feature in features),
getattr(connection.features, feature, False) for feature in features
),
"Database has feature(s) %s" % ", ".join(features), "Database has feature(s) %s" % ", ".join(features),
"skipIfDBFeature", "skipIfDBFeature",
) )

4
tests/test_utils/tests.py
View File

@ -133,10 +133,10 @@ class SkippingTestCase(SimpleTestCase):
raise ValueError raise ValueError
self._assert_skipping(test_func, unittest.SkipTest) self._assert_skipping(test_func, unittest.SkipTest)
self._assert_skipping(test_func2, ValueError) self._assert_skipping(test_func2, AttributeError)
self._assert_skipping(test_func3, unittest.SkipTest) self._assert_skipping(test_func3, unittest.SkipTest)
self._assert_skipping(test_func4, unittest.SkipTest) self._assert_skipping(test_func4, unittest.SkipTest)
self._assert_skipping(test_func5, ValueError) self._assert_skipping(test_func5, AttributeError)
class SkipTestCase(SimpleTestCase): class SkipTestCase(SimpleTestCase):
@skipIfDBFeature("missing") @skipIfDBFeature("missing")