From 057175ffbda8a591ceeb7080ca89ad87395c5454 Mon Sep 17 00:00:00 2001
From: Tom Christie <tom@tomchristie.com>
Date: Thu, 9 Mar 2017 13:40:25 +0000
Subject: [PATCH] Graceful handling when API inputs malformed or missing

---
 .../static/rest_framework/docs/js/api.js      | 36 +++++++++++++------
 1 file changed, 26 insertions(+), 10 deletions(-)

diff --git a/rest_framework/static/rest_framework/docs/js/api.js b/rest_framework/static/rest_framework/docs/js/api.js
index d0efa751a..8cd9807d2 100644
--- a/rest_framework/static/rest_framework/docs/js/api.js
+++ b/rest_framework/static/rest_framework/docs/js/api.js
@@ -40,28 +40,44 @@ $('form.api-interaction').submit(function(event) {
     for (var [paramKey, paramValue] of formData.entries()) {
         var elem = form.find("[name=" + paramKey + "]")
         var dataType = elem.data('type') || 'string'
-        var dataLocation = elem.data('location')
 
         if (dataType === 'integer' && paramValue) {
-            paramValue = parseInt(paramValue)
+            let value = parseInt(paramValue)
+            if (!isNaN(value)) {
+              params[paramKey] = value
+            }
         } else if (dataType === 'number' && paramValue) {
-            paramValue = parseFloat(paramValue)
+            let value = parseFloat(paramValue)
+            if (!isNaN(value)) {
+              params[paramKey] = value
+            }
         } else if (dataType === 'boolean' && paramValue) {
-            paramValue = {
+            let value = {
                 'true': true,
                 'false': false
             }[paramValue.toLowerCase()]
+            if (value !== undefined) {
+              params[paramKey]
+            }
         } else if (dataType === 'array' && paramValue) {
-            paramValue = JSON.parse(paramValue)
+            try {
+              params[paramKey] = JSON.parse(paramValue)
+            } catch (err) {
+              // Ignore malformed JSON
+            }
+        } else if (dataType === 'object' && paramValue) {
+            try {
+              params[paramKey] = JSON.parse(paramValue)
+            } catch (err) {
+              // Ignore malformed JSON
+            }
+        } else if (dataType === 'string' && paramValue) {
+            params[paramKey] = paramValue
         }
-
-        if (dataLocation === 'query' && !paramValue) {
-            continue
-        }
-        params[paramKey] = paramValue
     }
 
     form.find(":checkbox").each(function( index ) {
+        // Handle unselected checkboxes
         var name = $(this).attr("name");
         if (!params.hasOwnProperty(name)) {
             params[name] = false