encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-07-27 08:29:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

Removed separate AsyncAPIView

Browse Source
This commit is contained in:
enrico 2022-08-25 16:50:16 +08:00
parent daac20aa85
commit 0a4001086b
2 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
rest_framework/views.py
View File

@ -484,7 +484,7 @@ class APIView(View):
# Note: Views are made CSRF exempt from within `as_view` as to prevent # Note: Views are made CSRF exempt from within `as_view` as to prevent
# accidental removal of this exemption in cases where `dispatch` needs to # accidental removal of this exemption in cases where `dispatch` needs to
# be overridden. # be overridden.
def dispatch(self, request, *args, **kwargs): def sync_dispatch(self, request, *args, **kwargs):
""" """
`.dispatch()` is pretty much the same as Django's regular dispatch, `.dispatch()` is pretty much the same as Django's regular dispatch,
but with extra hooks for startup, finalize, and exception handling. but with extra hooks for startup, finalize, and exception handling.
@ -513,18 +513,7 @@ class APIView(View):
self.response = self.finalize_response(request, response, *args, **kwargs) self.response = self.finalize_response(request, response, *args, **kwargs)
return self.response return self.response
def options(self, request, *args, **kwargs): async def async_dispatch(self, request, *args, **kwargs):
"""
Handler method for HTTP 'OPTIONS' request.
"""
if self.metadata_class is None:
return self.http_method_not_allowed(request, *args, **kwargs)
data = self.metadata_class().determine_metadata(request, self)
return Response(data, status=status.HTTP_200_OK)
class AsyncAPIView(APIView):
async def dispatch(self, request, *args, **kwargs):
""" """
`.dispatch()` is pretty much the same as Django's regular dispatch, `.dispatch()` is pretty much the same as Django's regular dispatch,
but with extra hooks for startup, finalize, and exception handling. but with extra hooks for startup, finalize, and exception handling.
@ -555,3 +544,18 @@ class AsyncAPIView(APIView):
self.response = self.finalize_response(request, response, *args, **kwargs) self.response = self.finalize_response(request, response, *args, **kwargs)
return self.response return self.response
def dispatch(self, request, *args, **kwargs):
if hasattr(self, 'view_is_async') and self.view_is_async:
return self.async_dispatch(request, *args, **kwargs)
else:
return self.sync_dispatch(request, *args, **kwargs)
def options(self, request, *args, **kwargs):
"""
Handler method for HTTP 'OPTIONS' request.
"""
if self.metadata_class is None:
return self.http_method_not_allowed(request, *args, **kwargs)
data = self.metadata_class().determine_metadata(request, self)
return Response(data, status=status.HTTP_200_OK)

4
tests/test_views.py
View File

@ -10,7 +10,7 @@ from rest_framework.decorators import api_view
from rest_framework.response import Response from rest_framework.response import Response
from rest_framework.settings import APISettings, api_settings from rest_framework.settings import APISettings, api_settings
from rest_framework.test import APIRequestFactory from rest_framework.test import APIRequestFactory
from rest_framework.views import APIView, AsyncAPIView from rest_framework.views import APIView
factory = APIRequestFactory() factory = APIRequestFactory()
@ -25,7 +25,7 @@ class BasicView(APIView):
return Response({'method': 'POST', 'data': request.data}) return Response({'method': 'POST', 'data': request.data})
class BasicAsyncView(AsyncAPIView): class BasicAsyncView(APIView):
async def get(self, request, *args, **kwargs): async def get(self, request, *args, **kwargs):
return Response({'method': 'GET'}) return Response({'method': 'GET'})