encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-07-23 22:49:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: double namespace

Browse Source 
When using namespaces on my apps and django generic relation project i get a double name space :
in relations.py i added this print statement on the line 383 before the matching viewname test
```
        print(
            f"Comparing '{match.view_name}' to '{expected_viewname}', self.view_name = {self.view_name} "
        )
```
and this is what i get in the console 
```
Comparing invoices:invoice-detail to reminders:invoices:invoice-detail, self.view_name = invoices:invoice-detail 
```

so i just added a test in     def get_versioned_viewname(self, viewname, request): to not change the view name i there is already a namespace.
This commit is contained in:
Altimore 2023-03-30 13:32:37 +04:00 committed by GitHub
parent 6b73acc173
commit 1381307c07
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rest_framework/versioning.py
View File

@ -135,8 +135,10 @@ class NamespaceVersioning(BaseVersioning):
) )
def get_versioned_viewname(self, viewname, request): def get_versioned_viewname(self, viewname, request):
return request.version + ':' + viewname if not ":" in viewname:
return request.version + ":" + viewname
else:
return viewname
class HostNameVersioning(BaseVersioning): class HostNameVersioning(BaseVersioning):
""" """