encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2024-11-25 11:04:02 +03:00
Code Issues Packages Projects Releases Wiki Activity

Schemas: Handle default=false for boolean fields (#7165)

Browse Source
This commit is contained in:
Stella 2020-01-29 10:20:51 +01:00 committed by GitHub
parent d21b8eb084
commit 160f912a60
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rest_framework/schemas/openapi.py
View File

@ -378,7 +378,7 @@ class AutoSchema(ViewInspector):
schema['writeOnly'] = True schema['writeOnly'] = True
if field.allow_null: if field.allow_null:
schema['nullable'] = True schema['nullable'] = True
if field.default and field.default != empty and not callable(field.default): if field.default is not None and field.default != empty and not callable(field.default):
schema['default'] = field.default schema['default'] = field.default
if field.help_text: if field.help_text:
schema['description'] = str(field.help_text) schema['description'] = str(field.help_text)

13
tests/schemas/test_openapi.py
View File

@ -70,6 +70,19 @@ class TestFieldMapping(TestCase):
data = inspector._map_serializer(Serializer()) data = inspector._map_serializer(Serializer())
assert isinstance(data['properties']['text']['description'], str), "description must be str" assert isinstance(data['properties']['text']['description'], str), "description must be str"
def test_boolean_default_field(self):
class Serializer(serializers.Serializer):
default_true = serializers.BooleanField(default=True)
default_false = serializers.BooleanField(default=False)
without_default = serializers.BooleanField()
inspector = AutoSchema()
data = inspector._map_serializer(Serializer())
assert data['properties']['default_true']['default'] is True, "default must be true"
assert data['properties']['default_false']['default'] is False, "default must be false"
assert 'default' not in data['properties']['without_default'], "default must not be defined"
@pytest.mark.skipif(uritemplate is None, reason='uritemplate not installed.') @pytest.mark.skipif(uritemplate is None, reason='uritemplate not installed.')
class TestOperationIntrospection(TestCase): class TestOperationIntrospection(TestCase):