encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-05 04:50:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Memoize object lookups in GenericApiView

Browse Source
This commit is contained in:
Ragheed Al-midani 2015-09-25 05:00:58 -04:00
parent 6284bceaaf
commit 16e7148d3b
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
rest_framework/generics.py
View File

@ -75,12 +75,19 @@ class GenericAPIView(views.APIView):
def get_object(self): def get_object(self):
""" """
Returns the object the view is displaying. Returns the object the view is displaying. The value is memoized across
the lifecycle of the view to reduce database hits when e.g. delegating
from custom actions in a ModelViewSet to built-in actions.
You may want to override this if you need to provide non-standard You may want to override this if you need to provide non-standard
queryset lookups. Eg if objects are referenced using multiple queryset lookups. Eg if objects are referenced using multiple
keyword arguments in the url conf. keyword arguments in the url conf.
""" """
# Check if obj has been looked up (and therefore memoized) before.
obj = getattr(self, 'obj', None)
if obj is not None:
return obj
queryset = self.filter_queryset(self.get_queryset()) queryset = self.filter_queryset(self.get_queryset())
# Perform the lookup filtering. # Perform the lookup filtering.
@ -99,6 +106,9 @@ class GenericAPIView(views.APIView):
# May raise a permission denied # May raise a permission denied
self.check_object_permissions(self.request, obj) self.check_object_permissions(self.request, obj)
# Memoize obj for potential lookups in the future.
self.obj = obj
return obj return obj
def get_serializer(self, *args, **kwargs): def get_serializer(self, *args, **kwargs):