From 177949472c6a5c934d6f4a9536f0c0fc714e7f7c Mon Sep 17 00:00:00 2001 From: Krystof Rehacek Date: Thu, 20 Jun 2019 11:46:22 +0200 Subject: [PATCH] save instance before setting m2m fields --- rest_framework/serializers.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index ae2e8fcc5..83ee0c8df 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -979,15 +979,13 @@ class ModelSerializer(Serializer): m2m_fields.append((attr, value)) else: setattr(instance, attr, value) - else: - m2m_fields.append((attr, value)) + + instance.save() for attr, value in m2m_fields: field = getattr(instance, attr) field.set(value) - instance.save() - return instance # Determine the fields to apply...