From 187e26e6af8bc41922dd2c51fb58f5699aaf0861 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20T=C3=B6rnqvist?= Date: Sun, 19 May 2013 15:09:57 +0300 Subject: [PATCH] Be strict with permission get in test --- rest_framework/tests/test_permissions.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/rest_framework/tests/test_permissions.py b/rest_framework/tests/test_permissions.py index 555139b81..a8108c115 100644 --- a/rest_framework/tests/test_permissions.py +++ b/rest_framework/tests/test_permissions.py @@ -39,14 +39,19 @@ class ModelPermissionsIntegrationTests(TestCase): def setUp(self): User.objects.create_user('disallowed', 'disallowed@example.com', 'password') user = User.objects.create_user('permitted', 'permitted@example.com', 'password') + # Keep get() lines clean and short + perm_kwargs = { + 'content_type__app_label': 'tests', + 'content_type__name': 'basic model', + } user.user_permissions = [ - Permission.objects.get(content_type__name='basic model', codename='add_basicmodel'), - Permission.objects.get(content_type__name='basic model', codename='change_basicmodel'), - Permission.objects.get(content_type__name='basic model', codename='delete_basicmodel') + Permission.objects.get(codename='add_basicmodel', **perm_kwargs), + Permission.objects.get(codename='change_basicmodel', **perm_kwargs), + Permission.objects.get(codename='delete_basicmodel', **perm_kwargs) ] user = User.objects.create_user('updateonly', 'updateonly@example.com', 'password') user.user_permissions = [ - Permission.objects.get(content_type__name='basic model', codename='change_basicmodel'), + Permission.objects.get(codename='change_basicmodel', **perm_kwargs), ] self.permitted_credentials = basic_auth_header('permitted', 'password')