encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-03 12:00:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

check for isinstance Page, prevents alt pagination

Browse Source 
when using DEFAULT_PAGINATION_SERIALIZER_CLASS and a custom paginator_class
BaseSerializer's checking for isinstance Page doesn't work.

the custom paginator_class has it's own Page that doesn't inherit from
django's base Page and thus its __iter__ method causes many=True, and
iterating over the page and trying to serialize the objects through
DEFAULT_PAGINATION_SERIALIZER_CLASS.
This commit is contained in:
Ross McFarland 2013-10-19 20:05:38 -07:00
parent c3aeb16557
commit 18d8f818e0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rest_framework/serializers.py
View File

@ -520,7 +520,7 @@ class BaseSerializer(WritableField):
if self.many is not None: if self.many is not None:
many = self.many many = self.many
else: else:
many = hasattr(obj, '__iter__') and not isinstance(obj, (Page, dict)) many = hasattr(obj, '__iter__') and not (isinstance(obj, dict) or hasattr(obj, 'next_page_number'))
if many: if many:
warnings.warn('Implict list/queryset serialization is deprecated. ' warnings.warn('Implict list/queryset serialization is deprecated. '
'Use the `many=True` flag when instantiating the serializer.', 'Use the `many=True` flag when instantiating the serializer.',