From 2227bc47f8b287b66775948ffb60b2d9378ac84f Mon Sep 17 00:00:00 2001 From: Carlton Gibson Date: Fri, 6 Apr 2018 12:15:30 +0200 Subject: [PATCH] Fix read_only + default validation --- rest_framework/serializers.py | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index d773902e8..7e84372de 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -441,6 +441,30 @@ class Serializer(BaseSerializer): return value + def _read_only_defaults(self): + fields = [ + field for field in self.fields.values() + if (field.read_only) and (field.default != empty) and (field.source != '*') and ('.' not in field.source) + ] + + defaults = OrderedDict() + for field in fields: + try: + default = field.get_default() + except SkipField: + continue + defaults[field.field_name] = default + + return defaults + + def run_validators(self, value): + """ + Add read_only fields with defaults to value before running validators. + """ + to_validate = self._read_only_defaults() + to_validate.update(value) + super(Serializer, self).run_validators(to_validate) + def to_internal_value(self, data): """ Dict of native values <- Dict of primitive datatypes. @@ -1477,6 +1501,12 @@ class ModelSerializer(Serializer): if (field.source != '*') and ('.' not in field.source) } + # Special Case: Add read_only fields with defaults. + field_names |= { + field.source for field in self.fields.values() + if (field.read_only) and (field.default != empty) and (field.source != '*') and ('.' not in field.source) + } + # Note that we make sure to check `unique_together` both on the # base model class, but also on any parent classes. validators = []