Add Meta.fields = '__all__' to serializer classes where required.

This commit is contained in:
Tom Christie 2016-06-02 12:33:34 +01:00
parent 53a356a380
commit 252ccf1e6b
10 changed files with 45 additions and 0 deletions

View File

@ -26,6 +26,7 @@ if django_filters:
class FilterableItemSerializer(serializers.ModelSerializer): class FilterableItemSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = FilterableItem model = FilterableItem
fields = '__all__'
# Basic filter on a list view. # Basic filter on a list view.
class FilterFieldsRootView(generics.ListCreateAPIView): class FilterFieldsRootView(generics.ListCreateAPIView):
@ -336,6 +337,7 @@ class SearchFilterModel(models.Model):
class SearchFilterSerializer(serializers.ModelSerializer): class SearchFilterSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = SearchFilterModel model = SearchFilterModel
fields = '__all__'
class SearchFilterTests(TestCase): class SearchFilterTests(TestCase):
@ -461,6 +463,7 @@ class SearchFilterModelM2M(models.Model):
class SearchFilterM2MSerializer(serializers.ModelSerializer): class SearchFilterM2MSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = SearchFilterModelM2M model = SearchFilterModelM2M
fields = '__all__'
class SearchFilterM2MTests(TestCase): class SearchFilterM2MTests(TestCase):
@ -511,6 +514,7 @@ class OrderingFilterRelatedModel(models.Model):
class OrderingFilterSerializer(serializers.ModelSerializer): class OrderingFilterSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = OrderingFilterModel model = OrderingFilterModel
fields = '__all__'
class DjangoFilterOrderingModel(models.Model): class DjangoFilterOrderingModel(models.Model):
@ -524,6 +528,7 @@ class DjangoFilterOrderingModel(models.Model):
class DjangoFilterOrderingSerializer(serializers.ModelSerializer): class DjangoFilterOrderingSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = DjangoFilterOrderingModel model = DjangoFilterOrderingModel
fields = '__all__'
class DjangoFilterOrderingTests(TestCase): class DjangoFilterOrderingTests(TestCase):

View File

@ -33,11 +33,13 @@ class Comment(RESTFrameworkModel):
class BasicSerializer(serializers.ModelSerializer): class BasicSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = BasicModel model = BasicModel
fields = '__all__'
class ForeignKeySerializer(serializers.ModelSerializer): class ForeignKeySerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = ForeignKeySource model = ForeignKeySource
fields = '__all__'
class SlugSerializer(serializers.ModelSerializer): class SlugSerializer(serializers.ModelSerializer):
@ -414,6 +416,7 @@ class ClassASerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = ClassA model = ClassA
fields = '__all__'
class ExampleView(generics.ListCreateAPIView): class ExampleView(generics.ListCreateAPIView):
@ -461,6 +464,7 @@ class DynamicSerializerView(generics.ListCreateAPIView):
class DynamicSerializer(serializers.ModelSerializer): class DynamicSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = TwoFieldModel model = TwoFieldModel
fields = '__all__'
return DynamicSerializer return DynamicSerializer

View File

@ -300,6 +300,7 @@ class TestModelSerializerMetadata(TestCase):
class Meta: class Meta:
model = Parent model = Parent
fields = '__all__'
class ExampleView(views.APIView): class ExampleView(views.APIView):
"""Example view.""" """Example view."""

View File

@ -141,6 +141,7 @@ class TestRegularFieldMappings(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = RegularFieldsModel model = RegularFieldsModel
fields = '__all__'
expected = dedent(""" expected = dedent("""
TestSerializer(): TestSerializer():
@ -173,6 +174,7 @@ class TestRegularFieldMappings(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = FieldOptionsModel model = FieldOptionsModel
fields = '__all__'
expected = dedent(""" expected = dedent("""
TestSerializer(): TestSerializer():
@ -306,6 +308,7 @@ class TestRegularFieldMappings(TestCase):
class Meta: class Meta:
model = RegularFieldsModel model = RegularFieldsModel
fields = '__all__'
class ChildSerializer(TestSerializer): class ChildSerializer(TestSerializer):
missing = serializers.ReadOnlyField() missing = serializers.ReadOnlyField()
@ -320,6 +323,7 @@ class TestRegularFieldMappings(TestCase):
class ExampleSerializer(serializers.ModelSerializer): class ExampleSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = ChoicesModel model = ChoicesModel
fields = '__all__'
ExampleSerializer() ExampleSerializer()
@ -327,6 +331,7 @@ class TestRegularFieldMappings(TestCase):
class ImplicitFieldsSerializer(serializers.ModelSerializer): class ImplicitFieldsSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = RegularFieldsModel model = RegularFieldsModel
fields = '__all__'
class ExplicitFieldsSerializer(serializers.ModelSerializer): class ExplicitFieldsSerializer(serializers.ModelSerializer):
class Meta: class Meta:
@ -350,6 +355,7 @@ class TestDurationFieldMapping(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = DurationFieldModel model = DurationFieldModel
fields = '__all__'
expected = dedent(""" expected = dedent("""
TestSerializer(): TestSerializer():
@ -367,6 +373,7 @@ class TestGenericIPAddressFieldValidation(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = IPAddressFieldModel model = IPAddressFieldModel
fields = '__all__'
s = TestSerializer(data={'address': 'not an ip address'}) s = TestSerializer(data={'address': 'not an ip address'})
self.assertFalse(s.is_valid()) self.assertFalse(s.is_valid())
@ -420,6 +427,7 @@ class TestRelationalFieldMappings(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = RelationalModel model = RelationalModel
fields = '__all__'
expected = dedent(""" expected = dedent("""
TestSerializer(): TestSerializer():
@ -436,6 +444,7 @@ class TestRelationalFieldMappings(TestCase):
class Meta: class Meta:
model = RelationalModel model = RelationalModel
depth = 1 depth = 1
fields = '__all__'
expected = dedent(""" expected = dedent("""
TestSerializer(): TestSerializer():
@ -459,6 +468,7 @@ class TestRelationalFieldMappings(TestCase):
class TestSerializer(serializers.HyperlinkedModelSerializer): class TestSerializer(serializers.HyperlinkedModelSerializer):
class Meta: class Meta:
model = RelationalModel model = RelationalModel
fields = '__all__'
expected = dedent(""" expected = dedent("""
TestSerializer(): TestSerializer():
@ -475,6 +485,7 @@ class TestRelationalFieldMappings(TestCase):
class Meta: class Meta:
model = RelationalModel model = RelationalModel
depth = 1 depth = 1
fields = '__all__'
expected = dedent(""" expected = dedent("""
TestSerializer(): TestSerializer():
@ -499,6 +510,8 @@ class TestRelationalFieldMappings(TestCase):
class Meta: class Meta:
model = UniqueTogetherModel model = UniqueTogetherModel
depth = 1 depth = 1
fields = '__all__'
expected = dedent(""" expected = dedent("""
TestSerializer(): TestSerializer():
url = HyperlinkedIdentityField(view_name='uniquetogethermodel-detail') url = HyperlinkedIdentityField(view_name='uniquetogethermodel-detail')
@ -600,6 +613,7 @@ class TestRelationalFieldDisplayValue(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = DisplayValueModel model = DisplayValueModel
fields = '__all__'
serializer = TestSerializer() serializer = TestSerializer()
expected = OrderedDict([('1', 'Red Color'), ('2', 'Yellow Color'), ('3', 'Green Color')]) expected = OrderedDict([('1', 'Red Color'), ('2', 'Yellow Color'), ('3', 'Green Color')])
@ -615,6 +629,7 @@ class TestRelationalFieldDisplayValue(TestCase):
class Meta: class Meta:
model = DisplayValueModel model = DisplayValueModel
fields = '__all__'
serializer = TestSerializer() serializer = TestSerializer()
expected = OrderedDict([('1', 'My Red Color'), ('2', 'My Yellow Color'), ('3', 'My Green Color')]) expected = OrderedDict([('1', 'My Red Color'), ('2', 'My Yellow Color'), ('3', 'My Green Color')])
@ -645,6 +660,7 @@ class TestIntegration(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = RelationalModel model = RelationalModel
fields = '__all__'
serializer = TestSerializer(self.instance) serializer = TestSerializer(self.instance)
expected = { expected = {
@ -660,6 +676,7 @@ class TestIntegration(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = RelationalModel model = RelationalModel
fields = '__all__'
new_foreign_key = ForeignKeyTargetModel.objects.create( new_foreign_key = ForeignKeyTargetModel.objects.create(
name='foreign_key' name='foreign_key'
@ -707,6 +724,7 @@ class TestIntegration(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = RelationalModel model = RelationalModel
fields = '__all__'
new_foreign_key = ForeignKeyTargetModel.objects.create( new_foreign_key = ForeignKeyTargetModel.objects.create(
name='foreign_key' name='foreign_key'
@ -875,6 +893,7 @@ class TestDecimalFieldMappings(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = DecimalFieldModel model = DecimalFieldModel
fields = '__all__'
serializer = TestSerializer() serializer = TestSerializer()
@ -888,6 +907,7 @@ class TestDecimalFieldMappings(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = DecimalFieldModel model = DecimalFieldModel
fields = '__all__'
serializer = TestSerializer() serializer = TestSerializer()
@ -901,6 +921,7 @@ class TestDecimalFieldMappings(TestCase):
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = DecimalFieldModel model = DecimalFieldModel
fields = '__all__'
serializer = TestSerializer() serializer = TestSerializer()

View File

@ -25,11 +25,13 @@ class AssociatedModel(RESTFrameworkModel):
class DerivedModelSerializer(serializers.ModelSerializer): class DerivedModelSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = ChildModel model = ChildModel
fields = '__all__'
class AssociatedModelSerializer(serializers.ModelSerializer): class AssociatedModelSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = AssociatedModel model = AssociatedModel
fields = '__all__'
# Tests # Tests

View File

@ -24,6 +24,7 @@ factory = APIRequestFactory()
class BasicSerializer(serializers.ModelSerializer): class BasicSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = BasicModel model = BasicModel
fields = '__all__'
class RootView(generics.ListCreateAPIView): class RootView(generics.ListCreateAPIView):
@ -215,6 +216,7 @@ class BasicPermModel(models.Model):
class BasicPermSerializer(serializers.ModelSerializer): class BasicPermSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = BasicPermModel model = BasicPermModel
fields = '__all__'
# Custom object-level permission, that includes 'view' permissions # Custom object-level permission, that includes 'view' permissions

View File

@ -15,6 +15,7 @@ class ForeignKeyTargetSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = ForeignKeyTarget model = ForeignKeyTarget
fields = '__all__'
class ForeignKeySourceSerializer(serializers.ModelSerializer): class ForeignKeySourceSerializer(serializers.ModelSerializer):
@ -25,6 +26,7 @@ class ForeignKeySourceSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = ForeignKeySource model = ForeignKeySource
fields = '__all__'
class NullableForeignKeySourceSerializer(serializers.ModelSerializer): class NullableForeignKeySourceSerializer(serializers.ModelSerializer):
@ -36,6 +38,7 @@ class NullableForeignKeySourceSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = NullableForeignKeySource model = NullableForeignKeySource
fields = '__all__'
# TODO: M2M Tests, FKTests (Non-nullable), One2One # TODO: M2M Tests, FKTests (Non-nullable), One2One

View File

@ -18,6 +18,7 @@ from tests.models import BasicModel
class BasicModelSerializer(serializers.ModelSerializer): class BasicModelSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = BasicModel model = BasicModel
fields = '__all__'
class MockPickleRenderer(BaseRenderer): class MockPickleRenderer(BaseRenderer):

View File

@ -125,6 +125,7 @@ class ValidationMaxValueValidatorModel(models.Model):
class ValidationMaxValueValidatorModelSerializer(serializers.ModelSerializer): class ValidationMaxValueValidatorModelSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = ValidationMaxValueValidatorModel model = ValidationMaxValueValidatorModel
fields = '__all__'
class UpdateMaxValueValidationModel(generics.RetrieveUpdateDestroyAPIView): class UpdateMaxValueValidationModel(generics.RetrieveUpdateDestroyAPIView):

View File

@ -21,6 +21,7 @@ class UniquenessModel(models.Model):
class UniquenessSerializer(serializers.ModelSerializer): class UniquenessSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = UniquenessModel model = UniquenessModel
fields = '__all__'
class RelatedModel(models.Model): class RelatedModel(models.Model):
@ -44,6 +45,7 @@ class AnotherUniquenessModel(models.Model):
class AnotherUniquenessSerializer(serializers.ModelSerializer): class AnotherUniquenessSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = AnotherUniquenessModel model = AnotherUniquenessModel
fields = '__all__'
class TestUniquenessValidation(TestCase): class TestUniquenessValidation(TestCase):
@ -134,11 +136,13 @@ class NullUniquenessTogetherModel(models.Model):
class UniquenessTogetherSerializer(serializers.ModelSerializer): class UniquenessTogetherSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = UniquenessTogetherModel model = UniquenessTogetherModel
fields = '__all__'
class NullUniquenessTogetherSerializer(serializers.ModelSerializer): class NullUniquenessTogetherSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = NullUniquenessTogetherModel model = NullUniquenessTogetherModel
fields = '__all__'
class TestUniquenessTogetherValidation(TestCase): class TestUniquenessTogetherValidation(TestCase):
@ -275,6 +279,7 @@ class UniqueForDateModel(models.Model):
class UniqueForDateSerializer(serializers.ModelSerializer): class UniqueForDateSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = UniqueForDateModel model = UniqueForDateModel
fields = '__all__'
class TestUniquenessForDateValidation(TestCase): class TestUniquenessForDateValidation(TestCase):