From 2ef15c65b388651fefc2fb50633c844693c24b6f Mon Sep 17 00:00:00 2001 From: Sergey Elfimov Date: Fri, 6 Oct 2023 19:53:30 +0300 Subject: [PATCH] add SerializerMethodWithParamsField --- rest_framework/fields.py | 22 ++++++++++++++++++++++ rest_framework/serializers.py | 2 +- tests/test_fields.py | 19 +++++++++++++++++++ 3 files changed, 42 insertions(+), 1 deletion(-) diff --git a/rest_framework/fields.py b/rest_framework/fields.py index 0b56fa7fb..0abe93a8f 100644 --- a/rest_framework/fields.py +++ b/rest_framework/fields.py @@ -1909,3 +1909,25 @@ class ModelField(Field): if is_protected_type(value): return value return self.model_field.value_to_string(obj) + + +class SerializerMethodWithParamsField(SerializerMethodField): + """ + A read-only field allows you to pass optional parameters to a method in a SerializerMethodField. + For example: + + class ExampleSerializer(Serializer): + extra_info = SerializerMethodWithParamsField(method_name='foo', bar='bar', ...) + + def foo(self, obj, **kwargs): + bar = kwargs.get('bar', None) + return ... # Calculate some data to return. + """ + + def __init__(self, method_name=None, **kwargs): + super().__init__(method_name, help_text=kwargs.pop('help_text', '')) + self._func_kwargs = kwargs + + def to_representation(self, value): + method = getattr(self.parent, self.method_name) + return method(value, **self._func_kwargs) diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index 77c181b6c..4e86fb580 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -55,7 +55,7 @@ from rest_framework.fields import ( # NOQA # isort:skip DictField, DurationField, EmailField, Field, FileField, FilePathField, FloatField, HiddenField, HStoreField, IPAddressField, ImageField, IntegerField, JSONField, ListField, ModelField, MultipleChoiceField, ReadOnlyField, - RegexField, SerializerMethodField, SlugField, TimeField, URLField, UUIDField, + RegexField, SerializerMethodField, SlugField, TimeField, URLField, UUIDField, SerializerMethodWithParamsField ) from rest_framework.relations import ( # NOQA # isort:skip HyperlinkedIdentityField, HyperlinkedRelatedField, ManyRelatedField, diff --git a/tests/test_fields.py b/tests/test_fields.py index 7006d473c..06b2fbfd4 100644 --- a/tests/test_fields.py +++ b/tests/test_fields.py @@ -2713,3 +2713,22 @@ class TestValidationErrorCode: ), ] } + + +# Tests for SerializerMethodWithParamsField. +# -------------------------------- + +class TestSerializerMethodWithParamsField: + def test_serializer_method_field(self): + class ExampleSerializer(serializers.Serializer): + example_field_1 = serializers.SerializerMethodWithParamsField(method_name='foo', bar='bar_1') + example_field_2 = serializers.SerializerMethodWithParamsField(method_name='foo', bar='bar_2') + + def foo(self, obj, **kwargs): + return 'ran foo(%d) with attr %s' % (obj['example_field'], kwargs.get('bar')) + + serializer = ExampleSerializer({'example_field': 123}) + assert serializer.data == { + 'example_field_1': 'ran foo(123) with attr bar_1', + 'example_field_2': 'ran foo(123) with attr bar_2', + }