From 31893cff745b8cb62c3cc98b7103af2860eca319 Mon Sep 17 00:00:00 2001 From: Nikolaus Schlemm Date: Sun, 19 May 2013 15:12:01 +0200 Subject: [PATCH] * make test assertion more explicit * cleanup --- rest_framework/tests/fields.py | 2 +- rest_framework/tests/views.py | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/rest_framework/tests/fields.py b/rest_framework/tests/fields.py index 6bc37db28..d0b352413 100644 --- a/rest_framework/tests/fields.py +++ b/rest_framework/tests/fields.py @@ -846,7 +846,7 @@ class HumanizedFieldType(TestCase): """ self.assertIsInstance(humanized, unicode) - self.assertTrue(humanized) + self.assertNotEqual(humanized, '') class HumanizedField(TestCase): diff --git a/rest_framework/tests/views.py b/rest_framework/tests/views.py index b70ef4ae2..994cf6dc3 100644 --- a/rest_framework/tests/views.py +++ b/rest_framework/tests/views.py @@ -6,8 +6,6 @@ from rest_framework.decorators import api_view from rest_framework.response import Response from rest_framework.settings import api_settings from rest_framework.views import APIView -from rest_framework import exceptions -from rest_framework import serializers import copy factory = RequestFactory() @@ -100,4 +98,3 @@ class FunctionBasedViewIntegrationTests(TestCase): } self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST) self.assertEqual(sanitise_json_error(response.data), expected) -